SCP-firmware merge requestshttps://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests2023-07-14T11:39:23Zhttps://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/810CMake: Add target info for fwk_test and mod_test in help2023-07-14T11:39:23ZDarryl GreenCMake: Add target info for fwk_test and mod_test in help*Created by: abhishek-arm*
This change adds missing target info for fwk_test and mod_test in cmake help to inform user about these unit testing targets.*Created by: abhishek-arm*
This change adds missing target info for fwk_test and mod_test in cmake help to inform user about these unit testing targets.https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/811Introduce PLATFORM_VARIANT for juno2023-07-12T08:41:18ZDarryl GreenIntroduce PLATFORM_VARIANT for juno*Created by: mdgzim01*
The PLATFORM_VARIANT option has been enabled for Juno platform which will allow the user to choose to build for `BOARD` or `FVP`. BOARD is the default value.
If the PLATFORM_VARIANT is 'FVP', the bl1 and bl2 i...*Created by: mdgzim01*
The PLATFORM_VARIANT option has been enabled for Juno platform which will allow the user to choose to build for `BOARD` or `FVP`. BOARD is the default value.
If the PLATFORM_VARIANT is 'FVP', the bl1 and bl2 images will be built.
If it is 'BOARD', the bl1-bypass and bl2 images will be built.https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/818dvfs: Add initial Unit Test2023-08-04T11:21:47ZDarryl Greendvfs: Add initial Unit Test*Created by: khaledAhmed-arm*
Add unit tests for function helpers of dvfs.
Change-Id: I7285d13fd77732e7f7658ee2e8db7bc1897dd027*Created by: khaledAhmed-arm*
Add unit tests for function helpers of dvfs.
Change-Id: I7285d13fd77732e7f7658ee2e8db7bc1897dd027https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/815scmi_clock/test: Add tests of invalid cases to clock rate set UT2023-07-14T11:40:03ZDarryl Greenscmi_clock/test: Add tests of invalid cases to clock rate set UT*Created by: mohamedasaker-arm*
Increase test coverage by adding tests for invalid cases
- test passing invalid message id to scmi_clock_message_handler expected response SCMI_NOT_FOUND
- test passing incorrect payload size to scmi_cl...*Created by: mohamedasaker-arm*
Increase test coverage by adding tests for invalid cases
- test passing invalid message id to scmi_clock_message_handler expected response SCMI_NOT_FOUND
- test passing incorrect payload size to scmi_clock_message_handler expected response SCMI_PROTOCOL_ERRORhttps://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/814module/power_domain: Update all power state variables upon report2023-07-26T12:40:02ZDarryl Greenmodule/power_domain: Update all power state variables upon report*Created by: mohamedasaker-arm*
pd->current_state is updated upon receiving a transition report; other state variables are not. This can be valid when the report results from a request. However, this won't be valid for non-requested tra...*Created by: mohamedasaker-arm*
pd->current_state is updated upon receiving a transition report; other state variables are not. This can be valid when the report results from a request. However, this won't be valid for non-requested transitions such as wakeup. Hence, update all state variables accordingly.
https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/813Fix "all-log-level" defect2023-07-17T11:07:49ZDarryl GreenFix "all-log-level" defect*Created by: niaste-arm*
Fix defects raised by the 'scp-tests-ci-all-log-levels' Jenkins Job in product/n1sdp, product/tc2, and morello when CPPcheck raises unused variable warnings when log level parameter is set to either 'DISABLED' o...*Created by: niaste-arm*
Fix defects raised by the 'scp-tests-ci-all-log-levels' Jenkins Job in product/n1sdp, product/tc2, and morello when CPPcheck raises unused variable warnings when log level parameter is set to either 'DISABLED' or 'CRIT'.https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/812SCMI-Perf Fastchannels, Ops split & Fixes2023-08-17T08:55:46ZDarryl GreenSCMI-Perf Fastchannels, Ops split & Fixes*Created by: nicola-mazzucato-arm*
This PR brings some improvements in code separation for SCMI-Perf and some fixes in perf-plugins-handler.*Created by: nicola-mazzucato-arm*
This PR brings some improvements in code separation for SCMI-Perf and some fixes in perf-plugins-handler.https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/809product/synquacer: prevent metadata from being updated on every boot2023-07-11T15:55:18ZDarryl Greenproduct/synquacer: prevent metadata from being updated on every boot*Created by: masahisak*
Current Trial Boot implementation for SynQuacer platform updates metadata on every boot even if the value is not changed. The metadata is stored in the NOR Flash, so updating NOR Flash should be minimized.
Thi...*Created by: masahisak*
Current Trial Boot implementation for SynQuacer platform updates metadata on every boot even if the value is not changed. The metadata is stored in the NOR Flash, so updating NOR Flash should be minimized.
This commit checks the accept flag, then updates the metadata when the value is changed and needs to be updated.
https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/808Enhanced `pl011` driver with simplification and extended functionality for `f...2023-06-23T07:24:22ZDarryl GreenEnhanced `pl011` driver with simplification and extended functionality for `fwk_io` module*Created by: leandro-arm*
This PR introduces several improvements:
- Initial unit tests for `pl011` driver
- Simplified `mod_pl011_init_ctx` function
- Removed redundant code in `pl011` driver
- Enhanced handling of TX buffer full...*Created by: leandro-arm*
This PR introduces several improvements:
- Initial unit tests for `pl011` driver
- Simplified `mod_pl011_init_ctx` function
- Removed redundant code in `pl011` driver
- Enhanced handling of TX buffer full condition
- Introducing `fwk_io_putch_nowait` function in `fwk_io` module
https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/802morello: Remove unused multichip info struct2023-06-21T12:24:45ZDarryl Greenmorello: Remove unused multichip info struct*Created by: wernerlewis*
Commit ee56f02cadf70726b2f2e869485a7b1bd2cec48e added the Morello system module, based on the N1SDP system module. This included a declaration of the struct morello_multichip_info, which was not used. This comm...*Created by: wernerlewis*
Commit ee56f02cadf70726b2f2e869485a7b1bd2cec48e added the Morello system module, based on the N1SDP system module. This included a declaration of the struct morello_multichip_info, which was not used. This commit removes this unused declaration.
Change-Id: I24aebb19a138137c433dcafd5dff25ae8f187b8ahttps://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/807cmn700: use offset adjusted address for remote chips2023-06-21T12:33:32ZDarryl Greencmn700: use offset adjusted address for remote chips*Created by: nissha03*
Adjust the address of SYSCACHE type region with chip address space offset while mapping the regions in CMN.
This change fixed the bug introduced in the previous change which wrongly maps local system cache addr...*Created by: nissha03*
Adjust the address of SYSCACHE type region with chip address space offset while mapping the regions in CMN.
This change fixed the bug introduced in the previous change which wrongly maps local system cache address in remote chip's without adjusting it with chip address space.
Change-Id: Ic3b47200b1d1646b8d0e746f0ba55caf7b616c5fhttps://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/801n1sdp: remove unused multichip info structure2023-06-21T12:24:55ZDarryl Greenn1sdp: remove unused multichip info structure*Created by: wernerlewis*
Commit 3980808137cf80f5be6a96b453ac9d3ed0f3c752 added support for N1SDP multichip configurations, using the struct n1sdp_multichip_info. Commit d2efba33e3b82398eea6b2ef344196b48940228c merged multichip informat...*Created by: wernerlewis*
Commit 3980808137cf80f5be6a96b453ac9d3ed0f3c752 added support for N1SDP multichip configurations, using the struct n1sdp_multichip_info. Commit d2efba33e3b82398eea6b2ef344196b48940228c merged multichip information into a new structure, but did not remove the declaration of n1sdp_multichip_info. This commit removes the declaration.
Change-Id: I3b14f568c7884ea3cb140fb7f2052c4e4dfe0673https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/800n1sdp: Remove exception_handler function from pcie_enumeration.c2023-06-13T18:22:43ZDarryl Greenn1sdp: Remove exception_handler function from pcie_enumeration.c*Created by: deepthip13*
The exception_handler function expects the stack to be setup with the core registers in a certain order by the parent caller function (arch_exception_invalid). For release builds, as part of the optimisations, t...*Created by: deepthip13*
The exception_handler function expects the stack to be setup with the core registers in a certain order by the parent caller function (arch_exception_invalid). For release builds, as part of the optimisations, the compiler inlines the exception_handler function within the caller - arch_exception_invalid function. But this is not true of debug builds, and where because of the explicit function call, the lr is pushed onto the stack. This changes the order of registers on the stack and defies what is expected by the callee (exception_handler).
This change gets rids of the exception_handler function, moves the handling within the callee into the caller in order to do away with an explicit function call, and retain the expected order of registers pushed on to the stack.
Change-Id: I72d380af649e9f5e597793a40dc86a2fe2a2f8aehttps://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/805Cmn700 refactoring2023-06-14T19:08:35ZDarryl GreenCmn700 refactoring*Created by: nissha03*
*Created by: nissha03*
https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/804optee mod unit test sample2023-08-08T15:24:35ZDarryl Greenoptee mod unit test sample*Created by: mohamedasaker-arm*
This PR provides a skeleton of an `optee` module unit test
*Created by: mohamedasaker-arm*
This PR provides a skeleton of an `optee` module unit test
https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/803Add driver for xr77128 (PMIC) module and enable voltage scaling in Morello (D...2023-06-12T09:15:18ZDarryl GreenAdd driver for xr77128 (PMIC) module and enable voltage scaling in Morello (DVFS)*Created by: himsha01*
*Created by: himsha01*
https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/796Add "disabled" log level2023-05-24T15:01:01ZDarryl GreenAdd "disabled" log level*Created by: niaste-arm*
Add a new 'disabled' log level to the framework that allows for the framework to be ran without producing log messages. Includes fixes for the Morello platform that prevents CppCheck from flagging unused variabl...*Created by: niaste-arm*
Add a new 'disabled' log level to the framework that allows for the framework to be ran without producing log messages. Includes fixes for the Morello platform that prevents CppCheck from flagging unused variables when log level is set to 'CRIT' and 'DISABLED' respectively.https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/799unit_test: Add template for Quick Start2023-06-20T13:25:36ZDarryl Greenunit_test: Add template for Quick Start*Created by: nicola-mazzucato-arm*
It's been some time since we introduced unit testing in the SCP-firmware project.
Even though the guidelines are pretty useful to get started, we want to simplify even further the adoption of unit tes...*Created by: nicola-mazzucato-arm*
It's been some time since we introduced unit testing in the SCP-firmware project.
Even though the guidelines are pretty useful to get started, we want to simplify even further the adoption of unit testing for the contributors who may still not familiar with it.
Thus, we provide a template that can be used as a first copy-paste example which, along with the instructions, can provide a quick starter into unit testing development.https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/797dockerfile: fix missing dependency for LLVM compiler2023-05-30T13:30:12ZDarryl Greendockerfile: fix missing dependency for LLVM compiler*Created by: leandro-arm*
There is a missing dependency for LLVM compiler that prevent the build to be linked. This patch fix this.
Change-Id: I9f3da99e243e2bd05f008d35e6a6c155192f4a15*Created by: leandro-arm*
There is a missing dependency for LLVM compiler that prevent the build to be linked. This patch fix this.
Change-Id: I9f3da99e243e2bd05f008d35e6a6c155192f4a15https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/795ut/user_guide: Clarify requirements for contributors2023-06-01T20:03:48ZDarryl Greenut/user_guide: Clarify requirements for contributors*Created by: nicola-mazzucato-arm*
A specific section is introduced to explain better what the expectations are from contributors with regards to unit testing.
In particular, it's worth noting that we are still in an introductory pha...*Created by: nicola-mazzucato-arm*
A specific section is introduced to explain better what the expectations are from contributors with regards to unit testing.
In particular, it's worth noting that we are still in an introductory phase and, although we encourage contributors to play & add with UT, we feel that it's fair to give everybody some time to get familiar with the tool and the way it's used within the project.