SCP-firmware merge requestshttps://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests2023-06-01T20:03:52Zhttps://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/760Total Compute: Add build variant for TC2 & deprecate TC02023-06-01T20:03:52ZDarryl GreenTotal Compute: Add build variant for TC2 & deprecate TC0*Created by: nicola-mazzucato-arm*
With this PR we add a build variant `EXPERIMENT_POWER` for TC2 and we deprecate TC0.
Guidance for deprecation is also added.*Created by: nicola-mazzucato-arm*
With this PR we add a build variant `EXPERIMENT_POWER` for TC2 and we deprecate TC0.
Guidance for deprecation is also added.https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/764SCMI-Perf: Fixes and Unit testing2023-06-01T20:03:51ZDarryl GreenSCMI-Perf: Fixes and Unit testing*Created by: nicola-mazzucato-arm*
This PR brings a couple of fixes and initial unit-testing for the plugins-handler extension.*Created by: nicola-mazzucato-arm*
This PR brings a couple of fixes and initial unit-testing for the plugins-handler extension.https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/791Perf-Plugins-Handler: Improvements and Unit Testing2023-06-01T20:03:50ZDarryl GreenPerf-Plugins-Handler: Improvements and Unit Testing*Created by: nicola-mazzucato-arm*
This PR brings fixes, improvements and unit testing for the Plugins Handler extension in SCMI-Performance.*Created by: nicola-mazzucato-arm*
This PR brings fixes, improvements and unit testing for the Plugins Handler extension in SCMI-Performance.https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/795ut/user_guide: Clarify requirements for contributors2023-06-01T20:03:48ZDarryl Greenut/user_guide: Clarify requirements for contributors*Created by: nicola-mazzucato-arm*
A specific section is introduced to explain better what the expectations are from contributors with regards to unit testing.
In particular, it's worth noting that we are still in an introductory pha...*Created by: nicola-mazzucato-arm*
A specific section is introduced to explain better what the expectations are from contributors with regards to unit testing.
In particular, it's worth noting that we are still in an introductory phase and, although we encourage contributors to play & add with UT, we feel that it's fair to give everybody some time to get familiar with the tool and the way it's used within the project.
https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/797dockerfile: fix missing dependency for LLVM compiler2023-05-30T13:30:12ZDarryl Greendockerfile: fix missing dependency for LLVM compiler*Created by: leandro-arm*
There is a missing dependency for LLVM compiler that prevent the build to be linked. This patch fix this.
Change-Id: I9f3da99e243e2bd05f008d35e6a6c155192f4a15*Created by: leandro-arm*
There is a missing dependency for LLVM compiler that prevent the build to be linked. This patch fix this.
Change-Id: I9f3da99e243e2bd05f008d35e6a6c155192f4a15https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/796Add "disabled" log level2023-05-24T15:01:01ZDarryl GreenAdd "disabled" log level*Created by: niaste-arm*
Add a new 'disabled' log level to the framework that allows for the framework to be ran without producing log messages. Includes fixes for the Morello platform that prevents CppCheck from flagging unused variabl...*Created by: niaste-arm*
Add a new 'disabled' log level to the framework that allows for the framework to be ran without producing log messages. Includes fixes for the Morello platform that prevents CppCheck from flagging unused variables when log level is set to 'CRIT' and 'DISABLED' respectively.https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/793ci_cmake: Warn users when script runs w/o docker support2023-05-19T09:42:38ZDarryl Greenci_cmake: Warn users when script runs w/o docker support*Created by: khaledAhmed-arm*
While running ci_cmake.py in case the host machine does not support docker inform the user.
Change-Id: I7ddd14b4074ca6d93c75f614e5fc474fe9c0494a*Created by: khaledAhmed-arm*
While running ci_cmake.py in case the host machine does not support docker inform the user.
Change-Id: I7ddd14b4074ca6d93c75f614e5fc474fe9c0494ahttps://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/790fwk_log: remove '\n' character from log prints2023-05-10T12:54:13ZDarryl Greenfwk_log: remove '\n' character from log prints*Created by: leandro-arm*
Currently, newline characters are optionally added to log messages even though `fwk_log` appends its own `FWK_LOG_TERMINATOR` string. This change removes the redundant newlines, improving the efficiency of log ...*Created by: leandro-arm*
Currently, newline characters are optionally added to log messages even though `fwk_log` appends its own `FWK_LOG_TERMINATOR` string. This change removes the redundant newlines, improving the efficiency of log output and simplifying the logging code by eliminating the need for newline search functions.
Change-Id: Ifc46ffe3e2e8d7da5fa7a095c7122706806fe8e1https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/789scmi_clock: add UT test cases2023-05-10T12:53:49ZDarryl Greenscmi_clock: add UT test cases*Created by: leandro-arm*
This patch adds unit test for the state and reference counting check and update functions.*Created by: leandro-arm*
This patch adds unit test for the state and reference counting check and update functions.https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/785N1sdp mcp-scp scmi communication fix2023-05-09T09:26:32ZDarryl GreenN1sdp mcp-scp scmi communication fix*Created by: sah01Kaushal*
Patchset contains 3 patches -
n1sdp: Add configs for timer and gtimer in MCP RAM firmware
n1sdp: fix broken SCP-MCP SCMI communication
n1sdp: port to generic modules for MCP-SCP SCMI communication*Created by: sah01Kaushal*
Patchset contains 3 patches -
n1sdp: Add configs for timer and gtimer in MCP RAM firmware
n1sdp: fix broken SCP-MCP SCMI communication
n1sdp: port to generic modules for MCP-SCP SCMI communicationhttps://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/787doc: framework: Update doc w/ structs for static tables2023-05-05T16:18:03ZDarryl Greendoc: framework: Update doc w/ structs for static tables*Created by: mfischer*
Update doc with static element table support.
Fixes: 0a6b545c ("fwk: Add support for static element tables")*Created by: mfischer*
Update doc with static element table support.
Fixes: 0a6b545c ("fwk: Add support for static element tables")https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/788fwk: fix missing references for `FWK_LOG_LEVEL_TRACE`2023-05-04T14:24:04ZDarryl Greenfwk: fix missing references for `FWK_LOG_LEVEL_TRACE`*Created by: leandro-arm*
This patch addresses an issue where a reference was missing after renaming from `FWK_LOG_LEVEL_DEBUG` to `FWK_LOG_LEVEL_TRACE`. The fix ensures all references are properly updated.
Change-Id: Icf1ea1386bb9...*Created by: leandro-arm*
This patch addresses an issue where a reference was missing after renaming from `FWK_LOG_LEVEL_DEBUG` to `FWK_LOG_LEVEL_TRACE`. The fix ensures all references are properly updated.
Change-Id: Icf1ea1386bb9cbaf4f04b875d3194c5b18cda2bdhttps://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/780Morello mcp-scp scmi communication fix2023-04-18T10:15:41ZDarryl GreenMorello mcp-scp scmi communication fix*Created by: sah01Kaushal*
Patchset contains 3 patches -
morello: Add configs for timer and gtimer in MCP RAM firmware
morello: fix broken SCP-MCP SCMI communication
morello: port to generic modules for MCP-SCP SCMI communication*Created by: sah01Kaushal*
Patchset contains 3 patches -
morello: Add configs for timer and gtimer in MCP RAM firmware
morello: fix broken SCP-MCP SCMI communication
morello: port to generic modules for MCP-SCP SCMI communicationhttps://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/782scp: Update change_log for v2.12.02023-04-14T15:20:22ZDarryl Greenscp: Update change_log for v2.12.0*Created by: AhmedImbabyGadallah*
RDN2 platform fails to boot. As a consequence, a github issue is raised and a temporary workaround provided. This is mentioned in change_log.md within this patch.
*Created by: AhmedImbabyGadallah*
RDN2 platform fails to boot. As a consequence, a github issue is raised and a temporary workaround provided. This is mentioned in change_log.md within this patch.
https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/779cli: Prepend carriage return to line feed2023-04-06T14:06:38ZDarryl Greencli: Prepend carriage return to line feed*Created by: mohamedasaker-arm*
After c15ff7e9505e3544daa4ac5329f302e536fe7acf
which removes the prepending carriage return from the drivers. It moves the responsibility of prepending carriage return to the user of the driver. This pat...*Created by: mohamedasaker-arm*
After c15ff7e9505e3544daa4ac5329f302e536fe7acf
which removes the prepending carriage return from the drivers. It moves the responsibility of prepending carriage return to the user of the driver. This patch is adding this logic to the cli.https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/777Release notes for SCP-firmware v2.122023-04-04T08:17:30ZDarryl GreenRelease notes for SCP-firmware v2.12*Created by: AhmedImbabyGadallah*
Update the change log to summarize the changes included in this release.
*Created by: AhmedImbabyGadallah*
Update the change log to summarize the changes included in this release.
https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/776Lb/fwk log2023-03-24T15:05:34ZDarryl GreenLb/fwk log*Created by: AhmedImbabyGadallah*
Rework fwk_log and fwk_io*Created by: AhmedImbabyGadallah*
Rework fwk_log and fwk_iohttps://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/775maintainers: Update list of maintainers2023-03-24T15:05:07ZDarryl Greenmaintainers: Update list of maintainers*Created by: khaledAhmed-arm*
Update core maintainers list.
Change-Id: I89c4c3060c41dfd58e3da98d3f37dfa1a48ab4e7*Created by: khaledAhmed-arm*
Update core maintainers list.
Change-Id: I89c4c3060c41dfd58e3da98d3f37dfa1a48ab4e7https://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/774scmi_clock/test: invoke the message_handler directly2023-03-24T10:51:12ZDarryl Greenscmi_clock/test: invoke the message_handler directly*Created by: mohamedasaker-arm*
Instead of binding APIs invoke the message_handler directly. To remove unnecessary code and simplify the test.
Change-Id: Id440d4ca6d951877e78e74374f00877d78d8559c*Created by: mohamedasaker-arm*
Instead of binding APIs invoke the message_handler directly. To remove unnecessary code and simplify the test.
Change-Id: Id440d4ca6d951877e78e74374f00877d78d8559chttps://gitlab.arm.com/firmware/SCP-firmware/-/merge_requests/772scmi_clock: clean up policy functions and return the SCMI agent's state inste...2023-03-23T11:53:12ZDarryl Greenscmi_clock: clean up policy functions and return the SCMI agent's state instead of the physical state*Created by: mohamedasaker-arm*
This patchset:
- cleans up the policy functions from the `scmi_clock` module. As seen in `c49f043`, due to the code complexity of the function can potentially introduce defects that can be difficult to...*Created by: mohamedasaker-arm*
This patchset:
- cleans up the policy functions from the `scmi_clock` module. As seen in `c49f043`, due to the code complexity of the function can potentially introduce defects that can be difficult to spot and maintain. Refactoring `mod_scmi_clock_config_set_policy` function also helps to reduce the number of function calls and processing time, which can improve performance and efficiency.
Furthermore, this commit refactors the module by removing all unnecessary parameters in helper functions.
In addition, removing the FWK_WEAK to enforce the current policy until further requirements.
- Return the SCMI agent's state instead of the physical state.
The current method of reading the clock state calls the Clock HAL directly, which can cause inconsistencies
between what is being read by Clock Hal and what is being set in the SCMI agent state table.
To address this, the existing `scmi_clock_get_agent_clock_state` helper function is used to read the clock
state in relation to the requesting SCMI agent. i.e. function returns the state expected by SCMI agent.