ietf-suit issueshttps://gitlab.arm.com/groups/research/ietf-suit/-/issues2023-04-01T08:38:24Zhttps://gitlab.arm.com/research/ietf-suit/suit-tool/-/issues/3Feqture Request: Append authentication-wrapper before signng2023-04-01T08:38:24ZKen TakayamaFeqture Request: Append authentication-wrapper before signngI want to use suit-tool just for signing a SUIT_Envelope without suit-authentication-wrapper.
## input
in CBOR Diagnostic
```
/ SUIT_Envelope_Tagged / 107({
/ suit-manifest / 3: << {
/ suit-manifest-version / 1: 1,
/ suit-mani...I want to use suit-tool just for signing a SUIT_Envelope without suit-authentication-wrapper.
## input
in CBOR Diagnostic
```
/ SUIT_Envelope_Tagged / 107({
/ suit-manifest / 3: << {
/ suit-manifest-version / 1: 1,
/ suit-manifest-sequence-number / 2: 0,
/ suit-common / 3: << {
/ suit-components / 2: [
[h'00']
]
} >>
} >>
})
```
in HEX
```
d86ba1034da3010102000346a10281814100
```
## expected output
in CBOR Diagnostic
```
/ SUIT_Envelope_Tagged / 107({
/ suit-authentication-wrapper / 2: << [
<< [
/ suit-digest-algorithm-id: / -16,
/ suit-digest-bytes: / h'24E625F997BE10115B889BCA160DAE2618298AF7D4D4CF86117A8E674AF34917'
] >>,
<< / COSE_Sign1_Tagged / 18([
/ protected: / << {
/ alg / 1: -7 / ES256 /
} >>,
/ unprotected: / {},
/ payload: / null,
/ signature: / h'33BDB88260D7CEA0DDF6DA3E362D921CDBE170C23C95AF1CC5A0084640DAEC2111530B42F86D434BBBF4B824E492B6579D9EA4BC7A7333C9995F105D65084BB8'
]) >>
] >>,
/ suit-manifest / 3: << {
/ suit-manifest-version / 1: 1,
/ suit-manifest-sequence-number / 2: 0,
/ suit-common / 3: << {
/ suit-components / 2: [
[h'00']
]
} >>
} >>
})
```
in HEX
```
d86ba2025873825824822f582024e625f997be10115b889bca160dae2618
298af7d4d4cf86117a8e674af34917584ad28443a10126a0f6584033bdb8
8260d7cea0ddf6da3e362d921cdbe170c23c95af1cc5a0084640daec2111
530b42f86d434bbbf4b824e492b6579d9ea4bc7a7333c9995f105d65084b
b8034da3010102000346a10281814100
```https://gitlab.arm.com/research/ietf-suit/suit-tool/-/issues/2README link doesn't match repo link2022-11-28T20:30:40ZDave ThalerREADME link doesn't match repo linkhttps://gitlab.arm.com/research/ietf-suit/suit-tool has a "Clone" button on the top right which shows the link as https://git.gitlab.arm.com/research/ietf-suit/suit-tool.git
However the README file instead shows the clone command as
```...https://gitlab.arm.com/research/ietf-suit/suit-tool has a "Clone" button on the top right which shows the link as https://git.gitlab.arm.com/research/ietf-suit/suit-tool.git
However the README file instead shows the clone command as
```
$ git clone https://github.com/ARMmbed/suit-manifest-generator.git
```https://gitlab.arm.com/research/ietf-suit/suit-tool/-/issues/1A bug around suit-text while creating depending manifests2022-08-09T12:50:16ZKen TakayamaA bug around suit-text while creating depending manifestsI'm Ken Takayama, one of a SUIT and TEEP implementer.
Thanks to your suit-tool, I could create appropriate manifests for TEEP usage.
This is a quick bug report of suit-tool, but there is no rush because I found a workaround.
If yo...I'm Ken Takayama, one of a SUIT and TEEP implementer.
Thanks to your suit-tool, I could create appropriate manifests for TEEP usage.
This is a quick bug report of suit-tool, but there is no rush because I found a workaround.
If you have plenty of time, please fix it.
**Title:**
A garbage key-value in suit-text while creating depending manifests
**Environment:**
Ubuntu/Linux, Python 3.6.9
**Steps to reproduce:**
```
$ ../bin/suit-tool create -i personalisation.json -o personalisation.suit
```
**Expected Result:**
```
/ text / 13:<<{
[h'4f502d544545', h'44f301', h'636f6e6669672e6a736f6e']:{
/ model-name / 2:'Personalised OP-TEE on TF-A
on TrustZone',
/ vendor-domain / 3:'tam.teep.example',
}
}>>,
```
**Actual Result:**
Same as <https://gitlab.arm.com/research/ietf-suit/suit-tool/-/tree/master/teep-example>
```
/ text / 13:<<{
[h'4f502d544545', h'44f301', h'636f6e6669672e6a736f6e']:{
/ model-name / 2:'Personalised OP-TEE on TF-A
on TrustZone',
/ vendor-domain / 3:'tam.teep.example',
}
[h'4f502d544545', h'44f301', h'edd94cd89d9c4cc89216b3ad5a2d5b8a', h'7461']:{
/ model-name / 2:'OP-TEE on TF-A on
TrustZone',
/ vendor-domain / 3:'teep.example',
}
}>>,
```
**Workaround:**
1. delete ` "src-file": "ta.json" ` line from personalisation.json.
2. execute commands separately like below.
```
$ ../bin/suit-tool create -i ta.json -o ta.suit
$ ../bin/suit-tool create -i personalisation.json -o personalisation.suit
```
**Severity/Priority:**
Low
**Note:**
I estimate that there is a side-effect around create.py L.218.
There might be a static value in suit_tool.create and it remains while creating depending manifests.
I'm sorry but I could not found the actual cause.