Skip to content
  • Arnaldo Carvalho de Melo's avatar
    tools headers: Sync {tools/,}arch/powerpc/include/uapi/asm/kvm.h · 1b8f5160
    Arnaldo Carvalho de Melo authored
    The changes in the 3214d01f ("KVM: PPC: Book3S: Provide information
    about hardware/firmware CVE workarounds") commit right now will not
    produce any change in the tools, but that is because we still need to
    improve tools/perf/trace/beauty/kvm_ioctl.sh to build per arch string
    tables, so that we avoid assigning multiple times to the same command
    string entry, i.e. multiple defines, for different arches, have the same
    value, causing this:
    
      In file included from trace/beauty/ioctl.c:82:0:
      /tmp/build/perf/trace/beauty/generated/ioctl/kvm_ioctl_array.c: In function ‘ioctl__scnprintf_kvm_cmd’:
      /tmp/build/perf/trace/beauty/generated/ioctl/kvm_ioctl_array.c:76:11: error: initialized field overwritten [-Werror=override-init]
      /tmp/build/perf/trace/beauty/generated/ioctl/kvm_ioctl_array.c:88:11: note: (near initialization for ‘kvm_ioctl_cmds[165]’)
      /tmp/build/perf/trace/beauty/generated/ioctl/kvm_ioctl_array.c:90:11: error: initialized field overwritten [-Werror=override-init]
        [0xa6] = "PPC_GET_SMMU_INFO",
                 ^~~~~~~~~~~~~~~~~~~
    
    So the onlye effect of updating the tools/ copy of ppc's kvm.h header
    is to silence these perf build warnings:
    
      Warning: Kernel ABI header at 'tools/include/uapi/linux/kvm.h' differs from latest version at 'include/uapi/linux/kvm.h'
      Warning: Kernel ABI header at 'tools/arch/powerpc/include/uapi/asm/kvm.h' differs from latest version at 'arch/powerpc/include/uapi/asm/kvm.h'
    
    At some point we should do what we did for the errno tables and create
    per-arch string translation tables for the KVM ioctl commands for the
    architectures supporting KVM, such as s/390, PowerPC, x86_64 and ARM.
    
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Paul Mackerras <paulus@ozlabs.org>
    Cc: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
    Cc: Thomas Richter <tmricht@linux.vnet.ibm.com>
    Cc: Wang Nan <wangnan0@huawei.com>
    Link: https://lkml.kernel.org/n/tip-jmcf78tqiudgn46zqfw2tgt2@git.kernel.org
    
    
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    1b8f5160