Commit 9219982b authored by Ulf Hansson's avatar Ulf Hansson Committed by Wolfram Sang
Browse files

i2c: nomadik: Fixup system suspend

For !CONFIG_PM_RUNTIME, the device were never put back into active
state while resuming.

For CONFIG_PM_RUNTIME, we blindly trusted the device to be inactive
while we were about to handle it at suspend late, which is just too

Even if the driver uses pm_runtime_put_sync() after each tranfer to
return it's runtime PM resources, there are no guarantees this will
actually mean the device will inactivated. The reason is that the PM
core will prevent runtime suspend during system suspend, and thus when
a transfer occurs during the early phases of system suspend the device
will be kept active after the transfer.

To handle both issues above, use pm_runtime_force_suspend|resume() from
the system suspend|resume callbacks.

Signed-off-by: default avatarUlf Hansson <>
Acked-by: default avatarLinus Walleij <>
Signed-off-by: default avatarWolfram Sang <>
parent 8e8782c7
......@@ -879,19 +879,19 @@ static irqreturn_t i2c_irq_handler(int irq, void *arg)
static int nmk_i2c_suspend_late(struct device *dev)
int ret;
ret = pm_runtime_force_suspend(dev);
if (ret)
return ret;
return 0;
static int nmk_i2c_resume_early(struct device *dev)
/* First go to the default state */
/* Then let's idle the pins until the next transfer happens */
return 0;
return pm_runtime_force_resume(dev);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment