1. 27 May, 2021 1 commit
    • Lee Jones's avatar
      i2c: busses: i2c-pnx: Provide descriptions for 'alg_data' data structure · 3e0f8672
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
       drivers/i2c/busses/i2c-pnx.c:147: warning: Function parameter or member 'alg_data' not described in 'i2c_pnx_start'
       drivers/i2c/busses/i2c-pnx.c:147: warning: Excess function parameter 'adap' description in 'i2c_pnx_start'
       drivers/i2c/busses/i2c-pnx.c:202: warning: Function parameter or member 'alg_data' not described in 'i2c_pnx_stop'
       drivers/i2c/busses/i2c-pnx.c:202: warning: Excess function parameter 'adap' description in 'i2c_pnx_stop'
       drivers/i2c/busses/i2c-pnx.c:231: warning: Function parameter or member 'alg_data' not described in 'i2c_pnx_master_xmit'
       drivers/i2c/busses/i2c-pnx.c:231: warning: Excess function parameter 'adap' description in 'i2c_pnx_master_xmit'
       drivers/i2c/busses/i2c-pnx.c:301: warning: Function parameter or member 'alg_data' not described in 'i2c_pnx_master_rcv'
       drivers/i2c/busses/i2c-pnx.c:301: warning: Excess function parameter 'adap' description in 'i2c_pnx_master_rcv'
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Acked-by: default avatarVladimir Zapolskiy <vz@mleia.com>
      Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
  2. 04 Jul, 2020 1 commit
  3. 18 Apr, 2020 1 commit
  4. 15 Jan, 2020 1 commit
  5. 17 May, 2018 1 commit
  6. 27 Oct, 2017 1 commit
  7. 29 Aug, 2017 1 commit
  8. 22 Aug, 2016 1 commit
  9. 30 Oct, 2015 1 commit
  10. 25 Oct, 2015 1 commit
  11. 23 Oct, 2015 1 commit
  12. 20 Oct, 2014 1 commit
  13. 16 Jan, 2014 1 commit
  14. 30 Oct, 2013 1 commit
  15. 28 Aug, 2013 1 commit
  16. 23 Aug, 2013 1 commit
    • Wolfram Sang's avatar
      i2c: move OF helpers into the core · 687b81d0
      Wolfram Sang authored
      I2C of helpers used to live in of_i2c.c but experience (from SPI) shows
      that it is much cleaner to have this in the core. This also removes a
      circular dependency between the helpers and the core, and so we can
      finally register child nodes in the core instead of doing this manually
      in each driver. So, fix the drivers and documentation, too.
      Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
  17. 15 Aug, 2013 1 commit
    • Jingoo Han's avatar
      i2c: pnx: add CONFIG_PM_SLEEP to suspend/resume functions · d2f18534
      Jingoo Han authored
      Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following
      build warning when CONFIG_PM_SLEEP is not selected. This is because
      sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when
      the CONFIG_PM_SLEEP is enabled.
      drivers/i2c/busses/i2c-pnx.c:599:12: warning: 'i2c_pnx_controller_suspend' defined but not used [-Wunused-function]
      drivers/i2c/busses/i2c-pnx.c:608:12: warning: 'i2c_pnx_controller_resume' defined but not used [-Wunused-function]
      Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
      Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
  18. 21 Feb, 2013 1 commit
  19. 22 Dec, 2012 1 commit
  20. 12 Sep, 2012 2 commits
    • Roland Stigge's avatar
      i2c: pnx: Fix read transactions of >= 2 bytes · c076ada4
      Roland Stigge authored
      On transactions with n>=2 bytes, the controller actually wrongly clocks in n+1
      bytes. This is caused by the (wrong) assumption that RFE in the Status Register
      is 1 iff there is no byte already ordered (via a dummy TX byte). This lead to
      the implementation of synchronized byte ordering, e.g.:
      Dummy-TX - RX - Dummy-TX - RX - ...
      But since RFE actually stays high after some Dummy-TX, it rather looks like:
      Dummy-TX - Dummy-TX - RX - Dummy-TX - RX - (RX)
      The last RX byte is clocked in by the bus controller, but ignored by the kernel
      when filling the userspace buffer.
      This patch fixes the issue by asking for RX via Dummy-TX asynchronously.
      Introducing a separate counter for TX bytes.
      Signed-off-by: default avatarRoland Stigge <stigge@antcom.de>
      Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
    • Roland Stigge's avatar
      i2c: pnx: Fix bit definitions · b3aafe80
      Roland Stigge authored
      The I2C Control Register bits RFDAIE and RFFIE were mixed up. In addition to
      this fix, this patch adds the missing bit DRSIE for completeness.
      Signed-off-by: default avatarRoland Stigge <stigge@antcom.de>
      Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
  21. 12 Jul, 2012 1 commit
  22. 12 May, 2012 3 commits
  23. 22 Apr, 2012 5 commits
  24. 12 May, 2011 1 commit
  25. 20 Apr, 2010 2 commits
  26. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      The script does the followings.
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
      The conversion was done in the following steps.
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
      6. percpu.h was updated not to include slab.h.
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
  27. 07 Mar, 2010 1 commit
    • Luotao Fu's avatar
      i2c-pnx: fix setting start/stop condition · ad0194e8
      Luotao Fu authored
      The start/stop condtions are set in different places repetedly in the i2c-pnx
      driver.  Beside in i2c_pnx_start and i2c_pnx_stop the start/stop bit are also
      set during the transfer of a i2c message in the master_xmit/rcv calls. This is
      wrong since we can't set the start/stop condition during the transaction of a
      single message any way. As a matter of fact, the driver will sometimes set both
      the start and the stop bits at one time. This can be easily reproduced by
      sending a simple read request like e.g
      struct i2c_msg msgs[] = {
      { addr, 0, 1, buf },
      { addr, I2C_M_RD, offset, buf }
      While processing the first message the i2c_pnx_master_xmit will set both the
      start_bit and the stop_bit, which will eventually confuse the slave.
      Fixed by remove setting start/stop condition from the transmit routines.
      Signed-off-by: default avatarLuotao Fu <l.fu@pengutronix.de>
      Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
  28. 12 Feb, 2010 5 commits