Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • J jg-open
  • Project information
    • Project information
    • Activity
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
    • Locked Files
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • linux-arm
  • jg-open
  • Repository
Switch branch/tag
  • jg-open
  • kernel
  • trace
  • trace.c
Find file BlameHistoryPermalink
  • Jackie Liu's avatar
    tracing: Fix missing osnoise tracer on max_latency · 424b650f
    Jackie Liu authored Sep 22, 2021
    The compiler warns when the data are actually unused:
    
      kernel/trace/trace.c:1712:13: error: ‘trace_create_maxlat_file’ defined but not used [-Werror=unused-function]
       1712 | static void trace_create_maxlat_file(struct trace_array *tr,
            |             ^~~~~~~~~~~~~~~~~~~~~~~~
    
    [Why]
    CONFIG_HWLAT_TRACER=n, CONFIG_TRACER_MAX_TRACE=n, CONFIG_OSNOISE_TRACER=y
    gcc report warns.
    
    [How]
    Now trace_create_maxlat_file will only take effect when
    CONFIG_HWLAT_TRACER=y or CONFIG_TRACER_MAX_TRACE=y. In fact, after
    adding osnoise trace, it also needs to take effect.
    
    Link: https://lore.kernel.org/all/c1d9e328-ad7c-920b-6c24-9e1598a6421c@infradead.org/
    Link: https://lkml.kernel.org/r/20210922025122.3268022-1-liu.yun@linux.dev
    
    Fixes: bce29ac9
    
     ("trace: Add osnoise tracer")
    Cc: Daniel Bristot de Oliveira <bristot@redhat.com>
    Suggested-by: default avatarSteven Rostedt <rostedt@goodmis.org>
    Reviewed-by: default avatarDaniel Bristot de Oliveira <bristot@kernel.org>
    Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
    Signed-off-by: default avatarJackie Liu <liuyun01@kylinos.cn>
    Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
    424b650f