Commit b508e114 authored by Jamie Iles's avatar Jamie Iles Committed by Thomas Huth
Browse files

scripts/arch-run: use ncat rather than nc.



On Red Hat 7+ and derived distributions, 'nc' is nmap-ncat, but on
Debian based distributions this is often netcat-openbsd.  Both are
mostly compatible with the important distinction that netcat-openbsd
does not shutdown the socket on stdin EOF without also passing '-N' as
an argument which is not supported on nmap-ncat.  This has the
unfortunate consequence of hanging qmp calls so tests like aarch64
its-migration never complete.

We're depending on ncat behaviour and nmap-ncat is available in all
major distributions.
Signed-off-by: default avatarJamie Iles <jamie@nuviainc.com>
Message-Id: <20200921103644.1718058-1-jamie@nuviainc.com>
Tested-by: default avatarThomas Huth <thuth@redhat.com>
Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
parent a1e07bc1
......@@ -101,13 +101,13 @@ timeout_cmd ()
qmp ()
{
echo '{ "execute": "qmp_capabilities" }{ "execute":' "$2" '}' | nc -U $1
echo '{ "execute": "qmp_capabilities" }{ "execute":' "$2" '}' | ncat -U $1
}
run_migration ()
{
if ! command -v nc >/dev/null 2>&1; then
echo "${FUNCNAME[0]} needs nc (netcat)" >&2
if ! command -v ncat >/dev/null 2>&1; then
echo "${FUNCNAME[0]} needs ncat (netcat)" >&2
return 2
fi
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment