Commit 3950746d authored by Nadav Amit's avatar Nadav Amit Committed by Ingo Molnar
Browse files

x86/alternatives: Add comment about module removal races

Add a comment to clarify that users of text_poke() must ensure that
no races with module removal take place.

Signed-off-by: default avatarNadav Amit <>
Signed-off-by: default avatarRick Edgecombe <>
Signed-off-by: default avatarPeter Zijlstra (Intel) <>
Cc: <>
Cc: <>
Cc: <>
Cc: <>
Cc: <>
Cc: <>
Cc: <>
Cc: Andy Lutomirski <>
Cc: Borislav Petkov <>
Cc: Dave Hansen <>
Cc: H. Peter Anvin <>
Cc: Linus Torvalds <>
Cc: Masami Hiramatsu <>
Cc: Rik van Riel <>
Cc: Thomas Gleixner <>

Signed-off-by: default avatarIngo Molnar <>
parent 241a1f22
......@@ -810,6 +810,11 @@ static void *__text_poke(void *addr, const void *opcode, size_t len)
* It means the size must be writable atomically and the address must be aligned
* in a way that permits an atomic write. It also makes sure we fit on a single
* page.
* Note that the caller must ensure that if the modified code is part of a
* module, the module would not be removed during poking. This can be achieved
* by registering a module notifier, and ordering module removal and patching
* trough a mutex.
void *text_poke(void *addr, const void *opcode, size_t len)
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment