Commit f29dfa53 authored by Pawan Gupta's avatar Pawan Gupta Committed by Ingo Molnar
Browse files

x86/bugs/multihit: Fix mitigation reporting when VMX is not in use

On systems that have virtualization disabled or unsupported, sysfs
mitigation for X86_BUG_ITLB_MULTIHIT is reported incorrectly as:

  $ cat /sys/devices/system/cpu/vulnerabilities/itlb_multihit
  KVM: Vulnerable

System is not vulnerable to DoS attack from a rogue guest when
virtualization is disabled or unsupported in the hardware. Change the
mitigation reporting for these cases.

Fixes: b8e8c830

 ("kvm: mmu: ITLB_MULTIHIT mitigation")
Reported-by: default avatarNelson Dsouza <>
Co-developed-by: default avatarSean Christopherson <>
Signed-off-by: default avatarSean Christopherson <>
Signed-off-by: default avatarPawan Gupta <>
Signed-off-by: default avatarIngo Molnar <>
Reviewed-by: default avatarTony Luck <>
Acked-by: default avatarThomas Gleixner <>
parent 76d10256
......@@ -80,6 +80,10 @@ The possible values in this file are:
- The processor is not vulnerable.
* - KVM: Mitigation: Split huge pages
- Software changes mitigate this issue.
* - KVM: Mitigation: VMX unsupported
- KVM is not vulnerable because Virtual Machine Extensions (VMX) is not supported.
* - KVM: Mitigation: VMX disabled
- KVM is not vulnerable because Virtual Machine Extensions (VMX) is disabled.
* - KVM: Vulnerable
- The processor is vulnerable, but no mitigation enabled
......@@ -31,6 +31,7 @@
#include <asm/intel-family.h>
#include <asm/e820/api.h>
#include <asm/hypervisor.h>
#include <asm/tlbflush.h>
#include "cpu.h"
......@@ -1549,7 +1550,12 @@ static ssize_t l1tf_show_state(char *buf)
static ssize_t itlb_multihit_show_state(char *buf)
if (itlb_multihit_kvm_mitigation)
if (!boot_cpu_has(X86_FEATURE_MSR_IA32_FEAT_CTL) ||
return sprintf(buf, "KVM: Mitigation: VMX unsupported\n");
else if (!(cr4_read_shadow() & X86_CR4_VMXE))
return sprintf(buf, "KVM: Mitigation: VMX disabled\n");
else if (itlb_multihit_kvm_mitigation)
return sprintf(buf, "KVM: Mitigation: Split huge pages\n");
return sprintf(buf, "KVM: Vulnerable\n");
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment