• Bjorn Andersson's avatar
    remoteproc: qcom: Drop pr_err in q6v5_xfer_mem_ownership() · 9f2a4342
    Bjorn Andersson authored
    The pr_err() in q6v5_xfer_mem_ownership() prints, upon failure, the
    memory range that failed to be transitioned. But on 32-bit architectures
    with CONFIG_PHYS_ADDR_T_64BIT set we cannot cast the phys_addr_t
    variable to a pointer, per below build error. Instead these should be
    formatted with %pap.
    
    In file included from include/linux/kernel.h:14:0,
                     from include/linux/clk.h:16,
                     from drivers/remoteproc/qcom_q6v5_pil.c:18:
    drivers/remoteproc/qcom_q6v5_pil.c: In function 'q6v5_xfer_mem_ownership':
    drivers/remoteproc/qcom_q6v5_pil.c:337:10: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
              (void *)addr, (void *)(addr + size),
              ^
    
    Most callers will upon failure print a specific error message describing
    which memory region that we failed to pass ownership of, so rather than
    fixing the format string this patch fixes up the last callers and drop
    the print from this function, saving us from spamming the log in most of
    these error cases.
    
    Fixes: 6c5a9dc2
    
     ("remoteproc: qcom: Make secure world call for mem ownership switch")
    Reported-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
    9f2a4342