Commit 2a20aa17 authored by Pavel Tatashin's avatar Pavel Tatashin Committed by Linus Torvalds
Browse files

sparc64/mm: set fields in deferred pages

Without deferred struct page feature (CONFIG_DEFERRED_STRUCT_PAGE_INIT),
flags and other fields in "struct page"es are never changed prior to
first initializing struct pages by going through __init_single_page().

With deferred struct page feature enabled there is a case where we set
some fields prior to initializing:

mem_init() {

When register_page_bootmem_info() is called only non-deferred struct
pages are initialized.  But, this function goes through some reserved
pages which might be part of the deferred, and thus are not yet

  .. setting fields here ..
  such as: page->freelist = (void *)type;

   init_reserved_page() <- Only if this is deferred reserved page
      memset(0) <-- Loose the set fields here

We end up with similar issue as in the previous patch, where currently
we do not observe problem as memory is zeroed.  But, if flag asserts are
changed we can start hitting issues.

Also, because in this patch series we will stop zeroing struct page
memory during allocation, we must make sure that struct pages are
properly initialized prior to using them.

The deferred-reserved pages are initialized in free_all_bootmem().
Therefore, the fix is to switch the above calls.


Signed-off-by: default avatarPavel Tatashin <>
Reviewed-by: default avatarSteven Sistare <>
Reviewed-by: default avatarDaniel Jordan <>
Reviewed-by: default avatarBob Picco <>
Acked-by: default avatarDavid S. Miller <>
Acked-by: default avatarMichal Hocko <>
Cc: Alexander Potapenko <>
Cc: Andrey Ryabinin <>
Cc: Ard Biesheuvel <>
Cc: Catalin Marinas <>
Cc: Christian Borntraeger <>
Cc: Dmitry Vyukov <>
Cc: Heiko Carstens <>
Cc: "H. Peter Anvin" <>
Cc: Ingo Molnar <>
Cc: Mark Rutland <>
Cc: Matthew Wilcox <>
Cc: Mel Gorman <>
Cc: Michal Hocko <>
Cc: Sam Ravnborg <>
Cc: Thomas Gleixner <>
Cc: Will Deacon <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 353b1e7b
......@@ -2540,9 +2540,16 @@ void __init mem_init(void)
high_memory = __va(last_valid_pfn << PAGE_SHIFT);
* Must be done after boot memory is put on freelist, because here we
* might set fields in deferred struct pages that have not yet been
* initialized, and free_all_bootmem() initializes all the reserved
* deferred pages for us.
* Set up the zero page, mark it reserved, so that page count
* is not manipulated when freeing the page from user ptes.
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment