Commit ae891a1b authored by Maxin B John's avatar Maxin B John Committed by Linus Torvalds
Browse files

devres: fix possible use after free

devres uses the pointer value as key after it's freed, which is safe but
triggers spurious use-after-free warnings on some static analysis tools.
Rearrange code to avoid such warnings.

Signed-off-by: default avatarMaxin B. John <>
Reviewed-by: default avatarRolf Eike Beer <>
Acked-by: default avatarTejun Heo <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 5190f0c0
......@@ -87,8 +87,8 @@ void devm_free_irq(struct device *dev, unsigned int irq, void *dev_id)
struct irq_devres match_data = { irq, dev_id };
free_irq(irq, dev_id);
WARN_ON(devres_destroy(dev, devm_irq_release, devm_irq_match,
free_irq(irq, dev_id);
......@@ -79,9 +79,9 @@ EXPORT_SYMBOL(devm_ioremap_nocache);
void devm_iounmap(struct device *dev, void __iomem *addr)
WARN_ON(devres_destroy(dev, devm_ioremap_release, devm_ioremap_match,
(void *)addr));
......@@ -500,7 +500,7 @@ void dmam_pool_destroy(struct dma_pool *pool)
struct device *dev = pool->dev;
WARN_ON(devres_destroy(dev, dmam_pool_release, dmam_pool_match, pool));
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment