1. 14 Jun, 2018 1 commit
  2. 12 Aug, 2017 1 commit
  3. 09 Jun, 2017 1 commit
  4. 20 Apr, 2017 1 commit
    • David Howells's avatar
      Annotate hardware config module parameters in sound/pci/ · 6192c41f
      David Howells authored
      
      
      When the kernel is running in secure boot mode, we lock down the kernel to
      prevent userspace from modifying the running kernel image.  Whilst this
      includes prohibiting access to things like /dev/mem, it must also prevent
      access by means of configuring driver modules in such a way as to cause a
      device to access or modify the kernel image.
      
      To this end, annotate module_param* statements that refer to hardware
      configuration and indicate for future reference what type of parameter they
      specify.  The parameter parser in the core sees this information and can
      skip such parameters with an error message if the kernel is locked down.
      The module initialisation then runs as normal, but just sees whatever the
      default values for those parameters is.
      
      Note that we do still need to do the module initialisation because some
      drivers have viable defaults set in case parameters aren't specified and
      some drivers support automatic configuration (e.g. PNP or PCI) in addition
      to manually coded parameters.
      
      This patch annotates drivers in sound/pci/.
      Suggested-by: default avatarAlan Cox <gnomes@lxorguk.ukuu.org.uk>
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      cc: Jaroslav Kysela <perex@perex.cz>
      cc: Takashi Iwai <tiwai@suse.com>
      cc: alsa-devel@alsa-project.org
      6192c41f
  5. 13 Nov, 2016 1 commit
  6. 02 Sep, 2016 1 commit
    • Julia Lawall's avatar
      ALSA: constify snd_pcm_ops structures · 6769e988
      Julia Lawall authored
      Check for snd_pcm_ops structures that are only stored in the ops field of a
      snd_soc_platform_driver structure or passed as the third argument to
      snd_pcm_set_ops.  The corresponding field or parameter is declared const,
      so snd_pcm_ops structures that have this property can be declared as const
      also.
      
      The semantic patch that makes this change is as follows:
      (http://coccinelle.lip6.fr/
      
      )
      
      // <smpl>
      @r disable optional_qualifier@
      identifier i;
      position p;
      @@
      static struct snd_pcm_ops i@p = { ... };
      
      @ok1@
      identifier r.i;
      struct snd_soc_platform_driver e;
      position p;
      @@
      e.ops = &i@p;
      
      @ok2@
      identifier r.i;
      expression e1, e2;
      position p;
      @@
      snd_pcm_set_ops(e1, e2, &i@p)
      
      @bad@
      position p != {r.p,ok1.p,ok2.p};
      identifier r.i;
      struct snd_pcm_ops e;
      @@
      e@i@p
      
      @depends on !bad disable optional_qualifier@
      identifier r.i;
      @@
      static
      +const
       struct snd_pcm_ops i = { ... };
      // </smpl>
      Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      6769e988
  7. 16 Apr, 2015 1 commit
    • Quentin Lambert's avatar
      ALSA: remove deprecated use of pci api · 412b979c
      Quentin Lambert authored
      Replace occurences of the pci api by appropriate call to the dma api.
      
      A simplified version of the semantic patch that finds this problem is as
      follows: (http://coccinelle.lip6.fr
      
      )
      
      @deprecated@
      idexpression id;
      position p;
      @@
      
      (
        pci_dma_supported@p ( id, ...)
      |
        pci_alloc_consistent@p ( id, ...)
      )
      
      @bad1@
      idexpression id;
      position deprecated.p;
      @@
      ...when != &id->dev
         when != pci_get_drvdata ( id )
         when != pci_enable_device ( id )
      (
        pci_dma_supported@p ( id, ...)
      |
        pci_alloc_consistent@p ( id, ...)
      )
      
      @depends on !bad1@
      idexpression id;
      expression direction;
      position deprecated.p;
      @@
      
      (
      - pci_dma_supported@p ( id,
      + dma_supported ( &id->dev,
      ...
      + , GFP_ATOMIC
        )
      |
      - pci_alloc_consistent@p ( id,
      + dma_alloc_coherent ( &id->dev,
      ...
      + , GFP_ATOMIC
        )
      )
      Signed-off-by: default avatarQuentin Lambert <lambert.quentin@gmail.com>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      412b979c
  8. 28 Jan, 2015 1 commit
  9. 02 Jan, 2015 1 commit
  10. 21 Oct, 2014 1 commit
  11. 12 Aug, 2014 1 commit
  12. 26 Feb, 2014 1 commit
  13. 12 Feb, 2014 1 commit
  14. 29 May, 2013 1 commit
    • Takashi Iwai's avatar
      ALSA: PCI: Remove superfluous pci_set_drvdata(pci, NULL) at remove · 20a24225
      Takashi Iwai authored
      
      
      As drvdata is cleared to NULL at probe failure or at removal by the
      driver core, we don't have to call pci_set_drvdata(pci, NULL) any
      longer in each driver.
      
      The only remaining pci_set_drvdata(NULL) is in azx_firmware_cb() in
      hda_intel.c.  Since this function itself releases the card instance,
      we need to clear drvdata here as well, so that it won't be released
      doubly in the remove callback.
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      20a24225
  15. 07 Dec, 2012 1 commit
  16. 24 Apr, 2012 1 commit
  17. 19 Dec, 2011 1 commit
  18. 31 Oct, 2011 1 commit
  19. 14 Sep, 2011 1 commit
    • Clemens Ladisch's avatar
      ALSA: mpu401: clean up interrupt specification · dba8b469
      Clemens Ladisch authored
      
      
      The semantics of snd_mpu401_uart_new()'s interrupt parameters are
      somewhat counterintuitive:  To prevent the function from allocating its
      own interrupt, either the irq number must be invalid, or the irq_flags
      parameter must be zero.  At the same time, the irq parameter being
      invalid specifies that the mpu401 code has to work without an interrupt
      allocated by the caller.  This implies that, if there is an interrupt
      and it is allocated by the caller, the irq parameter must be set to
      a valid-looking number which then isn't actually used.
      
      With the removal of IRQF_DISABLED, zero becomes a valid irq_flags value,
      which forces us to handle the parameters differently.
      
      This patch introduces a new flag MPU401_INFO_IRQ_HOOK for when the
      device interrupt is handled by the caller, and makes the allocation of
      the interrupt to depend only on the irq parameter.  As suggested by
      Takashi, the irq_flags parameter was dropped because, when used, it had
      the constant value IRQF_DISABLED.
      Signed-off-by: default avatarClemens Ladisch <clemens@ladisch.de>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      dba8b469
  20. 10 Jun, 2011 2 commits
    • Takashi Iwai's avatar
      ALSA: use KBUILD_MODNAME for request_irq argument in sound/pci/* · 934c2b6d
      Takashi Iwai authored
      
      
      The name argument of request_irq() appears in /proc/interrupts, and
      it's quite ugly when the name entry contains a space or special letters.
      In general, it's simpler and more readable when the module name appears
      there, so let's replace all entries with KBUILD_MODNAME.
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      934c2b6d
    • Takashi Iwai's avatar
      ALSA: Use KBUILD_MODNAME for pci_driver.name entries · 3733e424
      Takashi Iwai authored
      
      
      The convention for pci_driver.name entry in kernel drivers seem to be
      the module name or equivalent ones.  But, so far, almost all PCI sound
      drivers use more verbose name like "ABC Xyz (12)", and these are fairly
      confusing when appearing as a file name.
      
      This patch converts the all pci_driver.name entries in sound/pci/* to
      use KBUILD_MODNAME for more unified appearance.
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      3733e424
  21. 09 Feb, 2010 1 commit
  22. 25 Jun, 2009 1 commit
  23. 07 Apr, 2009 1 commit
  24. 05 Feb, 2009 1 commit
  25. 12 Jan, 2009 1 commit
  26. 13 Aug, 2008 1 commit
  27. 31 Jan, 2008 1 commit
    • Takashi Iwai's avatar
      [ALSA] Remove sound/driver.h · 9004acc7
      Takashi Iwai authored
      
      
      This header file exists only for some hacks to adapt alsa-driver
      tree.  It's useless for building in the kernel.  Let's move a few
      lines in it to sound/core.h and remove it.
      With this patch, sound/driver.h isn't removed but has just a single
      compile warning to include it.  This should be really killed in
      future.
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      Signed-off-by: default avatarJaroslav Kysela <perex@perex.cz>
      9004acc7
  28. 16 Oct, 2007 1 commit
  29. 20 Dec, 2006 1 commit
  30. 05 Oct, 2006 1 commit
    • David Howells's avatar
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells authored
      
      
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      handling.
      
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      
      	struct pt_regs *old_regs = set_irq_regs(regs);
      
      And put the old one back at the end:
      
      	set_irq_regs(old_regs);
      
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      
      In timer_interrupt(), this sort of change will be necessary:
      
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      
      Some notes on the interrupt handling in the drivers:
      
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
      
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
      
       (*) Various IRQ handler function pointers have been moved to type
           irq_handler_t.
      Signed-Off-By: default avatarDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
      7d12e780
  31. 12 Jul, 2006 1 commit
  32. 02 Jul, 2006 1 commit
  33. 27 Jun, 2006 1 commit
  34. 22 Jun, 2006 3 commits
  35. 27 Apr, 2006 1 commit
  36. 28 Mar, 2006 1 commit
  37. 03 Jan, 2006 1 commit