Skip to content
  • Roopa Prabhu's avatar
    bridge: Add bridge ifindex to bridge fdb notify msgs · 41c389d7
    Roopa Prabhu authored
    (This patch was previously posted as RFC at
    http://patchwork.ozlabs.org/patch/352677/
    
    )
    
    This patch adds NDA_MASTER attribute to neighbour attributes enum for
    bridge/master ifindex. And adds NDA_MASTER to bridge fdb notify msgs.
    
    Today bridge fdb notifications dont contain bridge information.
    Userspace can derive it from the port information in the fdb
    notification. However this is tricky in some scenarious.
    
    Example, bridge port delete notification comes before bridge fdb
    delete notifications. And we have seen problems in userspace
    when using libnl where, the bridge fdb delete notification handling code
    does not understand which bridge this fdb entry is part of because
    the bridge and port association has already been deleted.
    And these notifications (port membership and fdb) are generated on
    separate rtnl groups.
    
    Fixing the order of notifications could possibly solve the problem
    for some cases (I can submit a separate patch for that).
    
    This patch chooses to add NDA_MASTER to bridge fdb notify msgs
    because it not only solves the problem described above, but also helps
    userspace avoid another lookup into link msgs to derive the master index.
    
    Signed-off-by: default avatarRoopa Prabhu <roopa@cumulusnetworks.com>
    Acked-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    41c389d7