Commit 10262b0b authored by Heiner Kallweit's avatar Heiner Kallweit Committed by David S. Miller
Browse files

r8169: don't try to read counters if chip is in a PCI power-save state

Avoid log spam caused by trying to read counters from the chip whilst
it is in a PCI power-save state.

Reference: https://bugzilla.kernel.org/show_bug.cgi?id=107421

Fixes: 1ef7286e

 ("r8169: Dereference MMIO address immediately before use")
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0aaa8137
...@@ -1681,11 +1681,13 @@ static bool rtl8169_reset_counters(struct rtl8169_private *tp) ...@@ -1681,11 +1681,13 @@ static bool rtl8169_reset_counters(struct rtl8169_private *tp)
static bool rtl8169_update_counters(struct rtl8169_private *tp) static bool rtl8169_update_counters(struct rtl8169_private *tp)
{ {
u8 val = RTL_R8(tp, ChipCmd);
/* /*
* Some chips are unable to dump tally counters when the receiver * Some chips are unable to dump tally counters when the receiver
* is disabled. * is disabled. If 0xff chip may be in a PCI power-save state.
*/ */
if ((RTL_R8(tp, ChipCmd) & CmdRxEnb) == 0) if (!(val & CmdRxEnb) || val == 0xff)
return true; return true;
return rtl8169_do_counters(tp, CounterDump); return rtl8169_do_counters(tp, CounterDump);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment