Commit a26b0b53 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller
Browse files

net: aquantia: remove some redundant variable initializations

There are several variables being initialized that are being set later
and hence the initialization is redundant and can be removed. Remove
Signed-off-by: default avatarColin Ian King <>
Signed-off-by: default avatarDavid S. Miller <>
parent a6deaa99
......@@ -84,7 +84,7 @@ static int aq_pci_probe_get_hw_by_id(struct pci_dev *pdev,
const struct aq_hw_ops **ops,
const struct aq_hw_caps_s **caps)
int i = 0;
int i;
if (pdev->vendor != PCI_VENDOR_ID_AQUANTIA)
return -EINVAL;
......@@ -107,7 +107,7 @@ static int aq_pci_probe_get_hw_by_id(struct pci_dev *pdev,
int aq_pci_func_init(struct pci_dev *pdev)
int err = 0;
int err;
err = pci_set_dma_mask(pdev, DMA_BIT_MASK(64));
if (!err) {
......@@ -141,7 +141,7 @@ int aq_pci_func_alloc_irq(struct aq_nic_s *self, unsigned int i,
char *name, void *aq_vec, cpumask_t *affinity_mask)
struct pci_dev *pdev = self->pdev;
int err = 0;
int err;
if (pdev->msix_enabled || pdev->msi_enabled)
err = request_irq(pci_irq_vector(pdev, i), aq_vec_isr, 0,
......@@ -164,7 +164,7 @@ int aq_pci_func_alloc_irq(struct aq_nic_s *self, unsigned int i,
void aq_pci_func_free_irqs(struct aq_nic_s *self)
struct pci_dev *pdev = self->pdev;
unsigned int i = 0U;
unsigned int i;
for (i = 32U; i--;) {
if (!((1U << i) & self->msix_entry_mask))
......@@ -194,8 +194,8 @@ static void aq_pci_free_irq_vectors(struct aq_nic_s *self)
static int aq_pci_probe(struct pci_dev *pdev,
const struct pci_device_id *pci_id)
struct aq_nic_s *self = NULL;
int err = 0;
struct aq_nic_s *self;
int err;
struct net_device *ndev;
resource_size_t mmio_pa;
u32 bar;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment