Commit b4b67f26 authored by Scott Wood's avatar Scott Wood Committed by David S. Miller
Browse files

gianfar: Fix warnings when built on 64-bit

As part of defconfig consolidation using fragments, we'd like to be
able to have the same drivers enabled on 32-bit and 64-bit.  Gianfar
happens to only exist on 32-bit systems, and when building the
resulting 64-bit kernel warnings were produced.

A couple of the warnings are trivial, but the rfbptr code has deeper
issues.  It uses the virtual address as the DMA address, which again,
happens to work in the environments where this driver is currently
used, but is not the right thing to do.

Fixes: 45b679c9

 ("gianfar: Implement PAUSE frame generation
Signed-off-by: default avatarScott Wood <>
Signed-off-by: default avatarClaudiu Manoil <>
Signed-off-by: default avatarDavid S. Miller <>
parent 97493e6a
......@@ -2611,7 +2611,8 @@ static void gfar_clean_tx_ring(struct gfar_priv_tx_q *tx_queue)
if (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_IN_PROGRESS)) {
struct skb_shared_hwtstamps shhwtstamps;
u64 *ns = (u64*) (((u32)skb->data + 0x10) & ~0x7);
u64 *ns = (u64 *)(((uintptr_t)skb->data + 0x10) &
memset(&shhwtstamps, 0, sizeof(shhwtstamps));
shhwtstamps.hwtstamp = ns_to_ktime(*ns);
......@@ -3043,8 +3044,9 @@ int gfar_clean_rx_ring(struct gfar_priv_rx_q *rx_queue, int rx_work_limit)
/* Update Last Free RxBD pointer for LFC */
if (unlikely(priv->tx_actual_en)) {
bdp = gfar_rxbd_lastfree(rx_queue);
gfar_write(rx_queue->rfbptr, (u32)bdp);
u32 bdp_dma = gfar_rxbd_dma_lastfree(rx_queue);
gfar_write(rx_queue->rfbptr, bdp_dma);
return howmany;
......@@ -3563,7 +3565,6 @@ static noinline void gfar_update_link_state(struct gfar_private *priv)
struct phy_device *phydev = priv->phydev;
struct gfar_priv_rx_q *rx_queue = NULL;
int i;
struct rxbd8 *bdp;
if (unlikely(test_bit(GFAR_RESETTING, &priv->state)))
......@@ -3620,9 +3621,11 @@ static noinline void gfar_update_link_state(struct gfar_private *priv)
/* Turn last free buffer recording on */
if ((tempval1 & MACCFG1_TX_FLOW) && !tx_flow_oldval) {
for (i = 0; i < priv->num_rx_queues; i++) {
u32 bdp_dma;
rx_queue = priv->rx_queue[i];
bdp = gfar_rxbd_lastfree(rx_queue);
gfar_write(rx_queue->rfbptr, (u32)bdp);
bdp_dma = gfar_rxbd_dma_lastfree(rx_queue);
gfar_write(rx_queue->rfbptr, bdp_dma);
priv->tx_actual_en = 1;
......@@ -1310,13 +1310,18 @@ static inline int gfar_rxbd_unused(struct gfar_priv_rx_q *rxq)
return rxq->rx_ring_size + rxq->next_to_clean - rxq->next_to_use - 1;
static inline struct rxbd8 *gfar_rxbd_lastfree(struct gfar_priv_rx_q *rxq)
static inline u32 gfar_rxbd_dma_lastfree(struct gfar_priv_rx_q *rxq)
struct rxbd8 *bdp;
u32 bdp_dma;
int i;
i = rxq->next_to_use ? rxq->next_to_use - 1 : rxq->rx_ring_size - 1;
bdp = &rxq->rx_bd_base[i];
bdp_dma = lower_32_bits(rxq->rx_bd_dma_base);
bdp_dma += (uintptr_t)bdp - (uintptr_t)rxq->rx_bd_base;
return &rxq->rx_bd_base[i];
return bdp_dma;
irqreturn_t gfar_receive(int irq, void *dev_id);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment