Commit e9156cd2 authored by James Hughes's avatar James Hughes Committed by David S. Miller
Browse files

smsc95xx: Use skb_cow_head to deal with cloned skbs

The driver was failing to check that the SKB wasn't cloned
before adding checksum data.
Replace existing handling to extend/copy the header buffer
with skb_cow_head.

Signed-off-by: default avatarJames Hughes <>
Acked-by: default avatarEric Dumazet <>
Acked-by: default avatarWoojung Huh <>
Signed-off-by: default avatarDavid S. Miller <>
parent 74d209b8
......@@ -2001,13 +2001,13 @@ static struct sk_buff *smsc95xx_tx_fixup(struct usbnet *dev,
/* We do not advertise SG, so skbs should be already linearized */
if (skb_headroom(skb) < overhead) {
struct sk_buff *skb2 = skb_copy_expand(skb,
overhead, 0, flags);
/* Make writable and expand header space by overhead if required */
if (skb_cow_head(skb, overhead)) {
/* Must deallocate here as returning NULL to indicate error
* means the skb won't be deallocated in the caller.
skb = skb2;
if (!skb)
return NULL;
return NULL;
if (csum) {
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment