Commit f6521c58 authored by Paul Blakey's avatar Paul Blakey Committed by David S. Miller
Browse files

cls_flower: Fix comparing of old filter mask with new filter

We incorrectly compare the mask and the result is that we can't modify
an already existing rule.

Fix that by comparing correctly.

Fixes: 05cd271f

 ("cls_flower: Support multiple masks per priority")
Reported-by: default avatarVlad Buslov <>
Reviewed-by: default avatarRoi Dayan <>
Reviewed-by: default avatarJiri Pirko <>
Signed-off-by: default avatarPaul Blakey <>
Reviewed-by: default avatarSimon Horman <>
Signed-off-by: default avatarDavid S. Miller <>
parent de9dc650
......@@ -877,7 +877,7 @@ static int fl_check_assign_mask(struct cls_fl_head *head,
return PTR_ERR(newmask);
fnew->mask = newmask;
} else if (fold && fold->mask == fnew->mask) {
} else if (fold && fold->mask != fnew->mask) {
return -EINVAL;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment