1. 17 Jan, 2017 1 commit
  2. 08 Jan, 2017 1 commit
  3. 30 Dec, 2016 1 commit
  4. 24 Dec, 2016 1 commit
  5. 11 Dec, 2016 3 commits
  6. 06 Dec, 2016 2 commits
  7. 05 Dec, 2016 1 commit
  8. 04 Dec, 2016 1 commit
  9. 21 Nov, 2016 2 commits
  10. 18 Nov, 2016 1 commit
    • Alexey Dobriyan's avatar
      netns: make struct pernet_operations::id unsigned int · c7d03a00
      Alexey Dobriyan authored
      Make struct pernet_operations::id unsigned.
      There are 2 reasons to do so:
      This field is really an index into an zero based array and
      thus is unsigned entity. Using negative value is out-of-bound
      access by definition.
      On x86_64 unsigned 32-bit data which are mixed with pointers
      via array indexing or offsets added or subtracted to pointers
      are preffered to signed 32-bit data.
      "int" being used as an array index needs to be sign-extended
      to 64-bit before being used.
      	void f(long *p, int i)
        roughly translates to
      	movsx	rsi, esi
      	mov	rdi, [rsi+...]
      	call 	g
      MOVSX is 3 byte instruction which isn't necessary if the variable is
      unsigned because x86_64 is zero extending by default.
      Now, there is net_generic() function which, you guessed it right, uses
      "int" as an array index:
      	static inline void *net_generic(const struct net *net, int id)
      		ptr = ng->ptr[id - 1];
      And this function is used a lot, so those sign extensions add up.
      Patch snipes ~1730 bytes on allyesconfig kernel (without all junk
      messing with code generation):
      	add/remove: 0/0 grow/shrink: 70/598 up/down: 396/-2126 (-1730)
      Unfortunately some functions actually grow bigger.
      This is a semmingly random artefact of code generation with register
      allocator being used differently. gcc decides that some variable
      needs to live in new r8+ registers and every access now requires REX
      prefix. Or it is shifted into r12, so [r12+0] addressing mode has to be
      used which is longer than [r8]
      However, overall balance is in negative direction:
      	add/remove: 0/0 grow/shrink: 70/598 up/down: 396/-2126 (-1730)
      	function                                     old     new   delta
      	nfsd4_lock                                  3886    3959     +73
      	tipc_link_build_proto_msg                   1096    1140     +44
      	mac80211_hwsim_new_radio                    2776    2808     +32
      	tipc_mon_rcv                                1032    1058     +26
      	svcauth_gss_legacy_init                     1413    1429     +16
      	tipc_bcbase_select_primary                   379     392     +13
      	nfsd4_exchange_id                           1247    1260     +13
      	nfsd4_setclientid_confirm                    782     793     +11
      	put_client_renew_locked                      494     480     -14
      	ip_set_sockfn_get                            730     716     -14
      	geneve_sock_add                              829     813     -16
      	nfsd4_sequence_done                          721     703     -18
      	nlmclnt_lookup_host                          708     686     -22
      	nfsd4_lockt                                 1085    1063     -22
      	nfs_get_client                              1077    1050     -27
      	tcf_bpf_init                                1106    1076     -30
      	nfsd4_encode_fattr                          5997    5930     -67
      	Total: Before=154856051, After=154854321, chg -0.00%
      Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
  11. 03 Nov, 2016 5 commits
  12. 01 Nov, 2016 1 commit
  13. 31 Oct, 2016 1 commit
  14. 20 Oct, 2016 1 commit
    • Jarod Wilson's avatar
      net: use core MTU range checking in core net infra · 91572088
      Jarod Wilson authored
      - Merge __geneve_change_mtu back into geneve_change_mtu, set max_mtu
      - This one isn't quite as straight-forward as others, could use some
        closer inspection and testing
      - set min/max_mtu
      - set min/max_mtu, remove tun_net_change_mtu
      - Merge __vxlan_change_mtu back into vxlan_change_mtu
      - Set max_mtu to IP_MAX_MTU and retain dynamic MTU range checks in
        change_mtu function
      - This one is also not as straight-forward and could use closer inspection
        and testing from vxlan folks
      - set max_mtu of IP_MAX_MTU and retain dynamic MTU range checks in
        change_mtu function
      - set min/max_mtu, remove internal_dev_change_mtu
      - note: max_mtu wasn't checked previously, it's been set to 65535, which
        is the largest possible size supported
      - set min/max_mtu (note: max_mtu previously unchecked, used max of 65535)
      - min_mtu = 0, max_mtu = 65535
      - min_mtu = 0, max_mtu = 65535
      - min_mtu = 0, max_mtu = 65535
      - min_mtu = 68, max_mtu = 65535
      - min_mtu = 0, max_mtu = 65535
      CC: netdev@vger.kernel.org
      CC: Nicolas Dichtel <nicolas.dichtel@6wind.com>
      CC: Hannes Frederic Sowa <hannes@stressinduktion.org>
      CC: Tom Herbert <tom@herbertland.com>
      CC: Daniel Borkmann <daniel@iogearbox.net>
      CC: Alexander Duyck <alexander.h.duyck@intel.com>
      CC: Paolo Abeni <pabeni@redhat.com>
      CC: Jiri Benc <jbenc@redhat.com>
      CC: WANG Cong <xiyou.wangcong@gmail.com>
      CC: Roopa Prabhu <roopa@cumulusnetworks.com>
      CC: Pravin B Shelar <pshelar@ovn.org>
      CC: Sabrina Dubroca <sd@queasysnail.net>
      CC: Patrick McHardy <kaber@trash.net>
      CC: Stephen Hemminger <stephen@networkplumber.org>
      CC: Pravin Shelar <pshelar@nicira.com>
      CC: Maxim Krasnyansky <maxk@qti.qualcomm.com>
      Signed-off-by: default avatarJarod Wilson <jarod@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
  15. 18 Oct, 2016 1 commit
    • Nikolay Aleksandrov's avatar
      bridge: multicast: restore perm router ports on multicast enable · 7cb3f921
      Nikolay Aleksandrov authored
      Satish reported a problem with the perm multicast router ports not getting
      reenabled after some series of events, in particular if it happens that the
      multicast snooping has been disabled and the port goes to disabled state
      then it will be deleted from the router port list, but if it moves into
      non-disabled state it will not be re-added because the mcast snooping is
      still disabled, and enabling snooping later does nothing.
      Here are the steps to reproduce, setup br0 with snooping enabled and eth1
      added as a perm router (multicast_router = 2):
      1. $ echo 0 > /sys/class/net/br0/bridge/multicast_snooping
      2. $ ip l set eth1 down
      ^ This step deletes the interface from the router list
      3. $ ip l set eth1 up
      ^ This step does not add it again because mcast snooping is disabled
      4. $ echo 1 > /sys/class/net/br0/bridge/multicast_snooping
      5. $ bridge -d -s mdb show
      At this point we have mcast enabled and eth1 as a perm router (value = 2)
      but it is not in the router list which is incorrect.
      After this change:
      1. $ echo 0 > /sys/class/net/br0/bridge/multicast_snooping
      2. $ ip l set eth1 down
      ^ This step deletes the interface from the router list
      3. $ ip l set eth1 up
      ^ This step does not add it again because mcast snooping is disabled
      4. $ echo 1 > /sys/class/net/br0/bridge/multicast_snooping
      5. $ bridge -d -s mdb show
      router ports on br0: eth1
      Note: we can directly do br_multicast_enable_port for all because the
      querier timer already has checks for the port state and will simply
      expire if it's in blocking/disabled. See the comment added by
      commit 9aa66382 ("bridge: multicast: add a comment to
      br_port_state_selection about blocking state")
      Fixes: 561f1103
       ("bridge: Add multicast_snooping sysfs toggle")
      Reported-by: default avatarSatish Ashok <sashok@cumulusnetworks.com>
      Signed-off-by: default avatarNikolay Aleksandrov <nikolay@cumulusnetworks.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
  16. 13 Oct, 2016 2 commits
  17. 03 Oct, 2016 1 commit
  18. 25 Sep, 2016 2 commits
  19. 24 Sep, 2016 2 commits
  20. 13 Sep, 2016 1 commit
    • Vivien Didelot's avatar
      net: bridge: add helper to call /sbin/bridge-stp · 30843315
      Vivien Didelot authored
      If /sbin/bridge-stp is available on the system, bridge tries to execute
      it instead of the kernel implementation when starting/stopping STP.
      If anything goes wrong with /sbin/bridge-stp, bridge silently falls back
      to kernel STP, making hard to debug userspace STP.
      This patch adds a br_stp_call_user helper to start/stop userspace STP
      and debug errors from the program: abnormal exit status is stored in the
      lower byte and normal exit status is stored in higher byte.
      Below is a simple example on a kernel with dynamic debug enabled:
          # ln -s /bin/false /sbin/bridge-stp
          # brctl stp br0 on
          br0: failed to start userspace STP (256)
          # dmesg
          br0: /sbin/bridge-stp exited with code 1
          br0: failed to start userspace STP (256)
          br0: using kernel STP
      Signed-off-by: default avatarVivien Didelot <vivien.didelot@savoirfairelinux.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
  21. 12 Sep, 2016 3 commits
  22. 02 Sep, 2016 2 commits
  23. 01 Sep, 2016 2 commits
    • Roopa Prabhu's avatar
      rtnetlink: fdb dump: optimize by saving last interface markers · d297653d
      Roopa Prabhu authored
      fdb dumps spanning multiple skb's currently restart from the first
      interface again for every skb. This results in unnecessary
      iterations on the already visited interfaces and their fdb
      entries. In large scale setups, we have seen this to slow
      down fdb dumps considerably. On a system with 30k macs we
      see fdb dumps spanning across more than 300 skbs.
      To fix the problem, this patch replaces the existing single fdb
      marker with three markers: netdev hash entries, netdevs and fdb
      index to continue where we left off instead of restarting from the
      first netdev. This is consistent with link dumps.
      In the process of fixing the performance issue, this patch also
      re-implements fix done by
      commit 472681d5
       ("net: ndo_fdb_dump should report -EMSGSIZE to rtnl_fdb_dump")
      (with an internal fix from Wilson Kok) in the following ways:
      - change ndo_fdb_dump handlers to return error code instead
      of the last fdb index
      - use cb->args strictly for dump frag markers and not error codes.
      This is consistent with other dump functions.
      Below results were taken on a system with 1000 netdevs
      and 35085 fdb entries:
      before patch:
      $time bridge fdb show | wc -l
      real    1m11.791s
      user    0m0.070s
      sys 1m8.395s
      (existing code does not return all macs)
      after patch:
      $time bridge fdb show | wc -l
      real    0m2.017s
      user    0m0.113s
      sys 0m1.942s
      Signed-off-by: default avatarRoopa Prabhu <roopa@cumulusnetworks.com>
      Signed-off-by: default avatarWilson Kok <wkok@cumulusnetworks.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    • Nikolay Aleksandrov's avatar
      net: bridge: don't increment tx_dropped in br_do_proxy_arp · 85a3d4a9
      Nikolay Aleksandrov authored
      pskb_may_pull may fail due to various reasons (e.g. alloc failure), but the
      skb isn't changed/dropped and processing continues so we shouldn't
      increment tx_dropped.
      CC: Kyeyoon Park <kyeyoonp@codeaurora.org>
      CC: Roopa Prabhu <roopa@cumulusnetworks.com>
      CC: Stephen Hemminger <stephen@networkplumber.org>
      CC: bridge@lists.linux-foundation.org
      Fixes: 95850116
       ("bridge: Add support for IEEE 802.11 Proxy ARP")
      Signed-off-by: default avatarNikolay Aleksandrov <nikolay@cumulusnetworks.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
  24. 31 Aug, 2016 1 commit
  25. 30 Aug, 2016 1 commit