1. 11 May, 2010 3 commits
  2. 28 Apr, 2010 1 commit
  3. 22 Apr, 2010 2 commits
  4. 08 Apr, 2010 1 commit
  5. 03 Apr, 2010 1 commit
  6. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      The script does the followings.
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
      The conversion was done in the following steps.
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
      6. percpu.h was updated not to include slab.h.
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
  7. 25 Mar, 2010 2 commits
  8. 24 Mar, 2010 7 commits
  9. 19 Mar, 2010 5 commits
    • Dean Nelson's avatar
      PCI: cleanup error return for pcix get and set mmrbc functions · 7c9e2b1c
      Dean Nelson authored
      pcix_get_mmrbc() returns the maximum memory read byte count (mmrbc), if
      successful, or an appropriate error value, if not.
      Distinguishing errors from correct values and understanding the meaning of an
      error can be somewhat confusing in that:
      	correct values: 512, 1024, 2048, 4096
      	errors: -EINVAL  			-22
      		PCIBIOS_SET_FAILED		0x88
      The PCIBIOS_ errors are returned from the PCI functions generated by the
      PCI_OP_READ() and PCI_OP_WRITE() macros.
      In a similar manner, pcix_set_mmrbc() also returns the PCIBIOS_ error values
      returned from pci_read_config_[word|dword]() and pci_write_config_word().
      Following pcix_get_max_mmrbc()'s example, the following patch simply returns
      -EINVAL for all PCIBIOS_ errors encountered by pcix_get_mmrbc(), and -EINVAL
      or -EIO for those encountered by pcix_set_mmrbc().
      This simplification was chosen in light of the fact that none of the current
      callers of these functions are interested in the specific type of error
      encountered. In the future, should this change, one could simply create a
      function that maps each PCIBIOS_ error to a corresponding unique errno value,
      which could be called by pcix_get_max_mmrbc(), pcix_get_mmrbc(), and
      Additionally, this patch eliminates some unnecessary variables.
      Cc: stable@kernel.org
      Signed-off-by: default avatarDean Nelson <dnelson@redhat.com>
      Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
    • Dean Nelson's avatar
      PCI: fix access of PCI_X_CMD by pcix get and set mmrbc functions · bdc2bda7
      Dean Nelson authored
      An e1000 driver on a system with a PCI-X bus was always being returned
      a value of 135 from both pcix_get_mmrbc() and pcix_set_mmrbc(). This
      value reflects an error return of PCIBIOS_BAD_REGISTER_NUMBER from
      pci_bus_read_config_dword(,, cap + PCI_X_CMD,).
      This is because for a dword, the following portion of the PCI_OP_READ()
      	if (PCI_##size##_BAD) return PCIBIOS_BAD_REGISTER_NUMBER;
      expands to:
      	if (pos & 3) return PCIBIOS_BAD_REGISTER_NUMBER;
      And is always true for 'cap + PCI_X_CMD', which is 0xe4 + 2 = 0xe6. ('cap' is
      the result of calling pci_find_capability(, PCI_CAP_ID_PCIX).)
      The same problem exists for pci_bus_write_config_dword(,, cap + PCI_X_CMD,).
      In both cases, instead of calling _dword(), _word() should be called.
      Cc: stable@kernel.org
      Signed-off-by: default avatarDean Nelson <dnelson@redhat.com>
      Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
    • Paul Mundt's avatar
      PCI: kill off pci_register_set_vga_state() symbol export. · ded1d8f2
      Paul Mundt authored
      When pci_register_set_vga_state() was made __init, the EXPORT_SYMBOL() was
      retained, which now leaves us with a section mismatch.
      Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
      Cc: Mike Travis <travis@sgi.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
    • Dean Nelson's avatar
      PCI: fix return value from pcix_get_max_mmrbc() · 25daeb55
      Dean Nelson authored
      For the PCI_X_STATUS register, pcix_get_max_mmrbc() is returning an incorrect
      value, which is based on:
      	(stat & PCI_X_STATUS_MAX_READ) >> 12
      Valid return values are 512, 1024, 2048, 4096, which correspond to a 'stat'
      (masked and right shifted by 21) of 0, 1, 2, 3, respectively.
      A right shift by 11 would generate the correct return value when 'stat' (masked
      and right shifted by 21) has a value of 1 or 2. But for a value of 0 or 3 it's
      not possible to generate the correct return value by only right shifting.
      Fix is based on pcix_get_mmrbc()'s similar dealings with the PCI_X_CMD register.
      Cc: stable@kernel.org
      Signed-off-by: default avatarDean Nelson <dnelson@redhat.com>
      Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
    • Mel Gorman's avatar
      sysfs: Initialised pci bus legacy_mem field before use · 6757eca3
      Mel Gorman authored
      PPC64 is failing to boot the latest mmotm due to an uninitialised pointer in
      pci_create_legacy_files(). The surprise is that machines boot at all and it
      would appear to affect current mainline as well.  This patch fixes the problem.
      Signed-off-by: default avatarMel Gorman <mel@csn.ul.ie>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
  10. 14 Mar, 2010 1 commit
  11. 12 Mar, 2010 3 commits
  12. 11 Mar, 2010 1 commit
    • Michal Simek's avatar
      microblaze: Enable PCI, missing files · a6475c13
      Michal Simek authored
      There are two parts of changes. The first is just enable
      PCI in Makefiles and in Kconfig. The second is the rest of
      missing files. I didn't want to add it with previous patch
      because that patch is too big.
      Current Microblaze toolchain has problem with weak symbols
      that's why is necessary to apply this changes to be possible
      to compile pci support.
      Xilinx knows about this problem.
      Signed-off-by: default avatarMichal Simek <monstr@monstr.eu>
  13. 08 Mar, 2010 4 commits
    • Greg Kroah-Hartman's avatar
      Driver core: create lock/unlock functions for struct device · 8e9394ce
      Greg Kroah-Hartman authored
      In the future, we are going to be changing the lock type for struct
      device (once we get the lockdep infrastructure properly worked out)  To
      make that changeover easier, and to possibly burry the lock in a
      different part of struct device, let's create some functions to lock and
      unlock a device so that no out-of-core code needs to be changed in the
      This patch creates the device_lock/unlock/trylock() functions, and
      converts all in-tree users to them.
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Jean Delvare <khali@linux-fr.org>
      Cc: Dave Young <hidave.darkstar@gmail.com>
      Cc: Ming Lei <tom.leiming@gmail.com>
      Cc: Jiri Kosina <jkosina@suse.cz>
      Cc: Phil Carmody <ext-phil.2.carmody@nokia.com>
      Cc: Arjan van de Ven <arjan@linux.intel.com>
      Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
      Cc: Rafael J. Wysocki <rjw@sisk.pl>
      Cc: Pavel Machek <pavel@ucw.cz>
      Cc: Len Brown <len.brown@intel.com>
      Cc: Magnus Damm <damm@igel.co.jp>
      Cc: Alan Stern <stern@rowland.harvard.edu>
      Cc: Randy Dunlap <randy.dunlap@oracle.com>
      Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>
      Cc: David Brownell <dbrownell@users.sourceforge.net>
      Cc: Vegard Nossum <vegard.nossum@gmail.com>
      Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
      Cc: Alex Chiang <achiang@hp.com>
      Cc: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Cc: Andrew Patterson <andrew.patterson@hp.com>
      Cc: Yu Zhao <yu.zhao@intel.com>
      Cc: Dominik Brodowski <linux@dominikbrodowski.net>
      Cc: Samuel Ortiz <sameo@linux.intel.com>
      Cc: Wolfram Sang <w.sang@pengutronix.de>
      Cc: CHENG Renquan <rqcheng@smu.edu.sg>
      Cc: Oliver Neukum <oliver@neukum.org>
      Cc: Frans Pop <elendil@planet.nl>
      Cc: David Vrabel <david.vrabel@csr.com>
      Cc: Kay Sievers <kay.sievers@vrfy.org>
      Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    • Stephen Rothwell's avatar
      sysfs: fix for thinko with sysfs_bin_attr_init() · 62e877b8
      Stephen Rothwell authored
      After merging the final tree, today's linux-next build (powerpc
      allyesconfig) failed like this:
      drivers/pci/pci-sysfs.c: In function 'pci_create_legacy_files':
      drivers/pci/pci-sysfs.c:645: error: lvalue required as unary '&' operand
      drivers/pci/pci-sysfs.c:658: error: lvalue required as unary '&' operand
      Caused by commit "sysfs: Use sysfs_attr_init and sysfs_bin_attr_init on
      dynamic attributes" interacting with commit "sysfs: Use one lockdep
      class per sysfs attribute") both from the driver-core tree.
      Signed-off-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Cc: "Eric W. Biederman" <ebiederm@xmission.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    • Eric W. Biederman's avatar
      sysfs: Use sysfs_attr_init and sysfs_bin_attr_init on dynamic attributes · a07e4156
      Eric W. Biederman authored
      These are the non-static sysfs attributes that exist on
      my test machine.  Fix them to use sysfs_attr_init or
      sysfs_bin_attr_init as appropriate.   It simply requires
      making a sysfs attribute present to see this.  So this
      is a little bit tedious but otherwise not too bad.
      Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
      Acked-by: default avatarWANG Cong <xiyou.wangcong@gmail.com>
      Cc: Tejun Heo <tj@kernel.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    • Emese Revfy's avatar
      Driver core: Constify struct sysfs_ops in struct kobj_type · 52cf25d0
      Emese Revfy authored
      Constify struct sysfs_ops.
      This is part of the ops structure constification
      effort started by Arjan van de Ven et al.
      Benefits of this constification:
       * prevents modification of data that is shared
         (referenced) by many other structure instances
         at runtime
       * detects/prevents accidental (but not intentional)
         modification attempts on archs that enforce
         read-only kernel data at runtime
       * potentially better optimized code as the compiler
         can assume that the const data cannot be changed
       * the compiler/linker move const data into .rodata
         and therefore exclude them from false sharing
      Signed-off-by: default avatarEmese Revfy <re.emese@gmail.com>
      Acked-by: default avatarDavid Teigland <teigland@redhat.com>
      Acked-by: default avatarMatt Domsch <Matt_Domsch@dell.com>
      Acked-by: default avatarMaciej Sosnowski <maciej.sosnowski@intel.com>
      Acked-by: default avatarHans J. Koch <hjk@linutronix.de>
      Acked-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
      Acked-by: default avatarJens Axboe <jens.axboe@oracle.com>
      Acked-by: default avatarStephen Hemminger <shemminger@vyatta.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
  14. 06 Mar, 2010 1 commit
  15. 05 Mar, 2010 1 commit
  16. 01 Mar, 2010 1 commit
  17. 28 Feb, 2010 2 commits
  18. 26 Feb, 2010 1 commit
    • Rafael J. Wysocki's avatar
      PM: Allow PCI devices to suspend/resume asynchronously · a1e4d72c
      Rafael J. Wysocki authored
      Set power.async_suspend for all PCI devices and PCIe port services,
      so that they can be suspended and resumed in parallel with other
      devices they don't depend on in a known way (i.e. devices which are
      not their parents or children).
      This only affects the "regular" suspend and resume stages, which
      means in particular that the restoration of the PCI devices' standard
      configuration registers during resume will still be carried out
      synchronously (at the "early" resume stage).
      Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
  19. 23 Feb, 2010 2 commits
    • Bjorn Helgaas's avatar
      PCI: augment bus resource table with a list · 2fe2abf8
      Bjorn Helgaas authored
      Previously we used a table of size PCI_BUS_NUM_RESOURCES (16) for resources
      forwarded to a bus by its upstream bridge.  We've increased this size
      several times when the table overflowed.
      But there's no good limit on the number of resources because host bridges
      and subtractive decode bridges can forward any number of ranges to their
      secondary buses.
      This patch reduces the table to only PCI_BRIDGE_RESOURCE_NUM (4) entries,
      which corresponds to the number of windows a PCI-to-PCI (3) or CardBus (4)
      bridge can positively decode.  Any additional resources, e.g., PCI host
      bridge windows or subtractively-decoded regions, are kept in a list.
      I'd prefer a single list rather than this split table/list approach, but
      that requires simultaneous changes to every architecture.  This approach
      only requires immediate changes where we set up (a) host bridges with more
      than four windows and (b) subtractive-decode P2P bridges, and we can
      incrementally change other architectures to use the list.
      Signed-off-by: default avatarBjorn Helgaas <bjorn.helgaas@hp.com>
      Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
    • Bjorn Helgaas's avatar
      PCI: add pci_bus_for_each_resource(), remove direct bus->resource[] refs · 89a74ecc
      Bjorn Helgaas authored
      No functional change; this converts loops that iterate from 0 to
      PCI_BUS_NUM_RESOURCES through pci_bus resource[] table to use the
      pci_bus_for_each_resource() iterator instead.
      This doesn't change the way resources are stored; it merely removes
      dependencies on the fact that they're in a table.
      Signed-off-by: default avatarBjorn Helgaas <bjorn.helgaas@hp.com>
      Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>