Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L linux-dm
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • linux-arm
  • linux-dm
  • Repository
  • linux-dm
  • Documentation
  • devicetree
  • bindings
  • net
  • snps,dwmac.yaml
Find file BlameHistoryPermalink
  • Alexandru Ardelean's avatar
    dt-bindings: net: dwmac: fix 'mac-mode' type · 9e5c8d39
    Alexandru Ardelean authored Sep 17, 2019
    The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type',
    which are enums of mode strings.
    
    The 'dwmac' driver supports almost all modes declared in the 'phy-mode'
    enum (except for 1 or 2). But in general, there may be a case where
    'mac-mode' becomes more generic and is moved as part of phylib or netdev.
    
    In any case, the 'mac-mode' field should be made an enum, and it also makes
    sense to just reference the 'phy-connection-type' from
    'ethernet-controller.yaml'. That will also make it more future-proof for new
    modes.
    
    Fixes: 9c15d359
    
     ("dt-bindings: net: dwmac: document 'mac-mode' property")
    Signed-off-by: default avatarAlexandru Ardelean <alexandru.ardelean@analog.com>
    Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
    Reviewed-by: default avatarRob Herring <robh@kernel.org>
    Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
    9e5c8d39