Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L linux-dm
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • linux-arm
  • linux-dm
  • Repository
Switch branch/tag
  • linux-dm
  • ..
  • mlxsw
  • devlink_trap_l2_drops.sh
Find file BlameHistoryPermalink
  • Ido Schimmel's avatar
    mlxsw: spectrum: Clear VLAN filters during port initialization · 979b9b25
    Ido Schimmel authored Sep 26, 2019
    When a port is created, its VLAN filters are not cleared by the
    firmware. This causes tagged packets to be later dropped by the ingress
    STP filters, which default to DISCARD state.
    
    The above did not matter much until commit b5ce611f ("mlxsw:
    spectrum: Add devlink-trap support") where we exposed the drop reason to
    users.
    
    Without this patch, the drop reason users will see is not consistent. If
    a port is enslaved to a VLAN-aware bridge and a packet with an invalid
    VLAN tries to ingress the bridge, it will be dropped due to ingress STP
    filter. If the VLAN is later enabled and then disabled, the packet will
    be dropped by the ingress VLAN filter despite the above being a
    seemingly NOP operation.
    
    Fix this by clearing all the VLAN filters during port initialization.
    Adjust the test accordingly.
    
    Fixes: b5ce611f
    
     ("mlxsw: spectrum: Add devlink-trap support")
    Reported-by: default avatarAlex Kushnarov <alexanderk@mellanox.com>
    Tested-by: default avatarAlex Kushnarov <alexanderk@mellanox.com>
    Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
    Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    979b9b25