Skip to content
  • Aneesh Kumar K.V's avatar
    powerpc/mm/radix: Move function from radix.h to pgtable-radix.c · 044003b5
    Aneesh Kumar K.V authored
    
    
    In later patch we will update them which require them to be moved
    to pgtable-radix.c. Keeping the function in radix.h results in
    compile warning as below.
    
    ./arch/powerpc/include/asm/book3s/64/radix.h: In function ‘radix__ptep_set_access_flags’:
    ./arch/powerpc/include/asm/book3s/64/radix.h:196:28: error: dereferencing pointer to incomplete type ‘struct vm_area_struct’
      struct mm_struct *mm = vma->vm_mm;
                                ^~
    ./arch/powerpc/include/asm/book3s/64/radix.h:204:6: error: implicit declaration of function ‘atomic_read’; did you mean ‘__atomic_load’? [-Werror=implicit-function-declaration]
          atomic_read(&mm->context.copros) > 0) {
          ^~~~~~~~~~~
          __atomic_load
    ./arch/powerpc/include/asm/book3s/64/radix.h:204:21: error: dereferencing pointer to incomplete type ‘struct mm_struct’
          atomic_read(&mm->context.copros) > 0) {
    
    Instead of fixing header dependencies, we move the function to pgtable-radix.c
    Also the function is now large to be a static inline . Doing the
    move in separate patch helps in review.
    
    No functional change in this patch. Only code movement.
    
    Signed-off-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    044003b5