Skip to content
  • Maciej Żenczykowski's avatar
    net-ipv6: fix excessive RTF_ADDRCONF flag on ::1/128 local route (and others) · d55a2e37
    Maciej Żenczykowski authored
    There is a subtle change in behaviour introduced by:
      commit c7a1ce39
      'ipv6: Change addrconf_f6i_alloc to use ip6_route_info_create'
    
    Before that patch /proc/net/ipv6_route includes:
    00000000000000000000000000000001 80 00000000000000000000000000000000 00 00000000000000000000000000000000 00000000 00000003 00000000 80200001 lo
    
    Afterwards /proc/net/ipv6_route includes:
    00000000000000000000000000000001 80 00000000000000000000000000000000 00 00000000000000000000000000000000 00000000 00000002 00000000 80240001 lo
    
    ie. the above commit causes the ::1/128 local (automatic) route to be flagged with RTF_ADDRCONF (0x040000).
    
    AFAICT, this is incorrect since these routes are *not* coming from RA's.
    
    As such, this patch restores the old behaviour.
    
    Fixes: c7a1ce39
    
     ("ipv6: Change addrconf_f6i_alloc to use ip6_route_info_create")
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Lorenzo Colitti <lorenzo@google.com>
    Signed-off-by: default avatarMaciej Żenczykowski <maze@google.com>
    Reviewed-by: default avatarDavid Ahern <dsahern@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    d55a2e37