Commit 06d7b5c3 authored by Vivien Didelot's avatar Vivien Didelot Committed by David S. Miller
Browse files

net: dsa: qca8k: fix EEE init

The qca8k obviously copied code from the sf2 driver as how to set EEE:

    if (e->eee_enabled) {
        p->eee_enabled = qca8k_eee_init(ds, port, phydev);
        if (!p->eee_enabled)
            ret = -EOPNOTSUPP;

But it did not use the same logic for the EEE init routine, which is
"Returns 0 if EEE was not enabled, or 1 otherwise". This results in
returning -EOPNOTSUPP on success and caching EEE enabled on failure.

This patch fixes the returned value of qca8k_eee_init.

Signed-off-by: default avatarVivien Didelot <>
Signed-off-by: default avatarDavid S. Miller <>
parent 7b9cc738
......@@ -666,11 +666,11 @@ qca8k_eee_init(struct dsa_switch *ds, int port,
ret = phy_init_eee(phy, 0);
if (ret)
return ret;
return 0;
qca8k_eee_enable_set(ds, port, true);
return 0;
return 1;
static int
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment