Commit 35b827b6 authored by Nicolas Dichtel's avatar Nicolas Dichtel Committed by David S. Miller
Browse files

tun: forbid iface creation with rtnl ops

It's not supported right now (the goal of the initial patch was to support
'ip link del' only).

Before the patch:
$ ip link add foo type tun
[  239.632660] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
[  239.636410] RIP: 0010:register_netdevice+0x8e/0x3a0

This panic occurs because dev->netdev_ops is not set by tun_setup(). But to
have something usable, it will require more than just setting

Fixes: f019a7a5

 ("tun: Implement ip link del tunXXX")
CC: Eric W. Biederman <>
Signed-off-by: default avatarNicolas Dichtel <>
Signed-off-by: default avatarDavid S. Miller <>
parent 436c9453
......@@ -2293,9 +2293,9 @@ static void tun_setup(struct net_device *dev)
static int tun_validate(struct nlattr *tb[], struct nlattr *data[],
struct netlink_ext_ack *extack)
if (!data)
return 0;
return -EINVAL;
"tun/tap creation via rtnetlink is not supported.");
static size_t tun_get_size(const struct net_device *dev)
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment