Commit e33b4325 authored by Yizhuo's avatar Yizhuo Committed by David S. Miller
Browse files

net: stmmac: dwmac-sun8i: Variable "val" in function sun8i_dwmac_set_syscon()...

net: stmmac: dwmac-sun8i: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized

In function sun8i_dwmac_set_syscon(), local variable "val" could
be uninitialized if function regmap_field_read() returns -EINVAL.
However, it will be used directly in the if statement, which
is potentially unsafe.

Signed-off-by: default avatarYizhuo <>
Signed-off-by: default avatarDavid S. Miller <>
parent 089cf7f6
......@@ -873,7 +873,12 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv)
int ret;
u32 reg, val;
regmap_field_read(gmac->regmap_field, &val);
ret = regmap_field_read(gmac->regmap_field, &val);
if (ret) {
dev_err(priv->device, "Fail to read from regmap field.\n");
return ret;
reg = gmac->variant->default_syscon_value;
if (reg != val)
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment