Commit f6ac438e authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Linus Walleij
Browse files

gpio: mockup: use devm_kcalloc() where applicable

When allocating a zeroed array of objects use devm_kcalloc() instead
of manually calculating the required size and using devm_kzalloc().

Signed-off-by: default avatarBartosz Golaszewski <>
Reviewed-by: default avatarAndy Shevchenko <>
Signed-off-by: default avatarLinus Walleij <>
parent c60c7f4c
......@@ -128,7 +128,7 @@ static int gpio_mockup_name_lines(struct device *dev,
char **names;
int i;
names = devm_kzalloc(dev, sizeof(char *) * gc->ngpio, GFP_KERNEL);
names = devm_kcalloc(dev, gc->ngpio, sizeof(char *), GFP_KERNEL);
if (!names)
return -ENOMEM;
......@@ -308,8 +308,8 @@ static int gpio_mockup_add(struct device *dev,
gc->get_direction = gpio_mockup_get_direction;
gc->to_irq = gpio_mockup_to_irq;
chip->lines = devm_kzalloc(dev, sizeof(*chip->lines) * gc->ngpio,
chip->lines = devm_kcalloc(dev, gc->ngpio,
sizeof(*chip->lines), GFP_KERNEL);
if (!chip->lines)
return -ENOMEM;
......@@ -346,7 +346,7 @@ static int gpio_mockup_probe(struct platform_device *pdev)
/* Each chip is described by two values. */
num_chips = gpio_mockup_params_nr / 2;
chips = devm_kzalloc(dev, sizeof(*chips) * num_chips, GFP_KERNEL);
chips = devm_kcalloc(dev, num_chips, sizeof(*chips), GFP_KERNEL);
if (!chips)
return -ENOMEM;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment