1. 24 Sep, 2019 1 commit
  2. 29 Aug, 2019 3 commits
  3. 11 Jul, 2019 1 commit
  4. 27 Jun, 2019 1 commit
    • David Howells's avatar
      keys: Replace uid/gid/perm permissions checking with an ACL · 2e12256b
      David Howells authored
      Replace the uid/gid/perm permissions checking on a key with an ACL to allow
      the SETATTR and SEARCH permissions to be split.  This will also allow a
      greater range of subjects to represented.
      WHY DO THIS?
      The problem is that SETATTR and SEARCH cover a slew of actions, not all of
      which should be grouped together.
      For SETATTR, this includes actions that are about controlling access to a
       (1) Changing a key's ownership.
       (2) Changing a key's security information.
       (3) Setting a keyring's restriction.
      And actions that are about managing a key's lifetime:
       (4) Setting an expiry time.
       (5) Revoking a key.
      and (proposed) managing a key as part of a cache:
       (6) Invalidating a key.
      Managing a key's lifetime doesn't really have anything to do with
      controlling access to that key.
      Expiry time is awkward since it's more about the lifetime of the content
      and so, in some ways goes better with WRITE permission.  It can, however,
      be set unconditionally by a process with an appropriate authorisation token
      for instantiating a key, and can also be set by the key type driver when a
      key is instantiated, so lumping it with the access-controlling actions is
      probably okay.
      As for SEARCH permission, that currently covers:
       (1) Finding keys in a keyring tree during a search.
       (2) Permitting keyrings to be joined.
       (3) Invalidation.
      But these don't really belong together either, since these actions really
      need to be controlled separately.
      Finally, there are number of special cases to do with granting the
      administrator special rights to invalidate or clear keys that I would like
      to handle with the ACL rather than key flags and special checks.
      The SETATTR permission is split to create two new permissions:
       (1) SET_SECURITY - which allows the key's owner, group and ACL to be
           changed and a restriction to be placed on a keyring.
       (2) REVOKE - which allows a key to be revoked.
      The SEARCH permission is split to create:
       (1) SEARCH - which allows a keyring to be search and a key to be found.
       (2) JOIN - which allows a keyring to be joined as a session keyring.
       (3) INVAL - which allows a key to be invalidated.
      The WRITE permission is also split to create:
       (1) WRITE - which allows a key's content to be altered and links to be
           added, removed and replaced in a keyring.
       (2) CLEAR - which allows a keyring to be cleared completely.  This is
           split out to make it possible to give just this to an administrator.
       (3) REVOKE - see above.
      Keys acquire ACLs which consist of a series of ACEs, and all that apply are
      unioned together.  An ACE specifies a subject, such as:
       (*) Possessor - permitted to anyone who 'possesses' a key
       (*) Owner - permitted to the key owner
       (*) Group - permitted to the key group
       (*) Everyone - permitted to everyone
      Note that 'Other' has been replaced with 'Everyone' on the assumption that
      you wouldn't grant a permit to 'Other' that you wouldn't also grant to
      everyone else.
      Further subjects may be made available by later patches.
      The ACE also specifies a permissions mask.  The set of permissions is now:
      	VIEW		Can view the key metadata
      	READ		Can read the key content
      	WRITE		Can update/modify the key content
      	SEARCH		Can find the key by searching/requesting
      	LINK		Can make a link to the key
      	SET_SECURITY	Can change owner, ACL, expiry
      	INVAL		Can invalidate
      	REVOKE		Can revoke
      	JOIN		Can join this keyring
      	CLEAR		Can clear this keyring
      The KEYCTL_SETPERM function is then deprecated.
      The KEYCTL_SET_TIMEOUT function then is permitted if SET_SECURITY is set,
      or if the caller has a valid instantiation auth token.
      The KEYCTL_INVALIDATE function then requires INVAL.
      The KEYCTL_REVOKE function then requires REVOKE.
      The KEYCTL_JOIN_SESSION_KEYRING function then requires JOIN to join an
      existing keyring.
      The JOIN permission is enabled by default for session keyrings and manually
      created keyrings only.
      To maintain backward compatibility, KEYCTL_SETPERM will translate the
      permissions mask it is given into a new ACL for a key - unless
      KEYCTL_SET_ACL has been called on that key, in which case an error will be
      It will convert possessor, owner, group and other permissions into separate
      ACEs, if each portion of the mask is non-zero.
      SETATTR permission turns on all of INVAL, REVOKE and SET_SECURITY.  WRITE
      permission turns on WRITE, REVOKE and, if a keyring, CLEAR.  JOIN is turned
      on if a keyring is being altered.
      The KEYCTL_DESCRIBE function translates the ACL back into a permissions
      mask to return depending on possessor, owner, group and everyone ACEs.
      It will make the following mappings:
       (1) INVAL, JOIN -> SEARCH
       (3) REVOKE -> WRITE if SETATTR isn't already set
       (4) CLEAR -> WRITE
      Note that the value subsequently returned by KEYCTL_DESCRIBE may not match
      the value set with KEYCTL_SETATTR.
      This passes the keyutils testsuite for all but a couple of tests:
       (1) tests/keyctl/dh_compute/badargs: The first wrong-key-type test now
           returns EOPNOTSUPP rather than ENOKEY as READ permission isn't removed
           if the type doesn't have ->read().  You still can't actually read the
       (2) tests/keyctl/permitting/valid: The view-other-permissions test doesn't
           work as Other has been replaced with Everyone in the ACL.
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
  5. 30 Mar, 2019 2 commits
  6. 22 Dec, 2018 1 commit
    • Dan Williams's avatar
      libnvdimm/security: Quiet security operations · 37379cfc
      Dan Williams authored
      The security implementation is too chatty. For example, the common case
      is that security is not enabled / setup, and booting a qemu
      configuration currently yields:
          nvdimm nmem0: request_key() found no key
          nvdimm nmem0: failed to unlock dimm: -126
          nvdimm nmem1: request_key() found no key
          nvdimm nmem1: failed to unlock dimm: -126
      Convert all security related log messages to debug level.
      Cc: Dave Jiang <dave.jiang@intel.com>
      Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
  7. 21 Dec, 2018 5 commits
  8. 14 Dec, 2018 1 commit