Skip to content
  • Mark Rutland's avatar
    arm64: kasan: clear stale stack poison · 0d97e6d8
    Mark Rutland authored
    
    
    Functions which the compiler has instrumented for KASAN place poison on
    the stack shadow upon entry and remove this poison prior to returning.
    
    In the case of cpuidle, CPUs exit the kernel a number of levels deep in
    C code.  Any instrumented functions on this critical path will leave
    portions of the stack shadow poisoned.
    
    If CPUs lose context and return to the kernel via a cold path, we
    restore a prior context saved in __cpu_suspend_enter are forgotten, and
    we never remove the poison they placed in the stack shadow area by
    functions calls between this and the actual exit of the kernel.
    
    Thus, (depending on stackframe layout) subsequent calls to instrumented
    functions may hit this stale poison, resulting in (spurious) KASAN
    splats to the console.
    
    To avoid this, clear any stale poison from the idle thread for a CPU
    prior to bringing a CPU online.
    
    Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
    Acked-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
    Reviewed-by: default avatarAndrey Ryabinin <aryabinin@virtuozzo.com>
    Reviewed-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Cc: Alexander Potapenko <glider@google.com>
    Cc: Catalin Marinas <catalin.marinas@arm.com>
    Cc: Will Deacon <will.deacon@arm.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    0d97e6d8