Skip to content
  • Amir Goldstein's avatar
    ovl: use directory index entries for consistency verification · ad1d615c
    Amir Goldstein authored
    
    
    A directory index is a directory type entry in index dir with a
    "trusted.overlay.upper" xattr containing an encoded ovl_fh of the merge
    directory upper dir inode.
    
    On lookup of non-dir files, lower file is followed by origin file handle.
    On lookup of dir entries, lower dir is found by name and then compared
    to origin file handle. We only trust dir index if we verified that lower
    dir matches origin file handle, otherwise index may be inconsistent and
    we ignore it.
    
    If we find an indexed non-upper dir or an indexed merged dir, whose
    index 'upper' xattr points to a different upper dir, that means that the
    lower directory may be also referenced by another upper dir via redirect,
    so we fail the lookup on inconsistency error.
    
    To be consistent with directory index entries format, the association of
    index dir to upper root dir, that was stored by older kernels in
    "trusted.overlay.origin" xattr is now stored in "trusted.overlay.upper"
    xattr. This also serves as an indication that overlay was mounted with a
    kernel that support index directory entries. For backward compatibility,
    if an 'origin' xattr exists on the index dir we also verify it on mount.
    
    Directory index entries are going to be used for NFS export.
    
    Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
    Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
    ad1d615c