Commit 0607eb1d authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba
Browse files

Btrfs: fix missing error return if writeback for extent buffer never started

If lock_extent_buffer_for_io() fails, it returns a negative value, but its
caller btree_write_cache_pages() ignores such error. This means that a
call to flush_write_bio(), from lock_extent_buffer_for_io(), might have
failed. We should make btree_write_cache_pages() notice such error values
and stop immediatelly, making sure filemap_fdatawrite_range() returns an
error to the transaction commit path. A failure from flush_write_bio()
should also result in the endio callback end_bio_extent_buffer_writepage()
being invoked, which sets the BTRFS_FS_*_ERR bits appropriately, so that
there's no risk a transaction or log commit doesn't catch a writeback

Reviewed-by: default avatarJosef Bacik <>
Signed-off-by: default avatarFilipe Manana <>
Signed-off-by: default avatarDavid Sterba <>
parent eb5b64f1
......@@ -3978,6 +3978,10 @@ retry:
if (!ret) {
} else if (ret < 0) {
done = 1;
ret = write_one_eb(eb, wbc, &epd);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment