Commit 4e3ca3e0 authored by Sergey Senozhatsky's avatar Sergey Senozhatsky Committed by Linus Torvalds
Browse files

mm/mempool: allow NULL `pool' pointer in mempool_destroy()

mempool_destroy() does not tolerate a NULL mempool_t pointer argument and
performs a NULL-pointer dereference.  This requires additional attention
and effort from developers/reviewers and forces all mempool_destroy()
callers to do a NULL check

    if (pool)

Or, otherwise, be invalid mempool_destroy() users.

Tweak mempool_destroy() and NULL-check the pointer there.

Proposed by Andrew Morton.


Signed-off-by: default avatarSergey Senozhatsky <>
Acked-by: default avatarDavid Rientjes <>
Cc: Julia Lawall <>
Cc: Joe Perches <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 3942d299
......@@ -150,6 +150,9 @@ static void *remove_element(mempool_t *pool)
void mempool_destroy(mempool_t *pool)
if (unlikely(!pool))
while (pool->curr_nr) {
void *element = remove_element(pool);
pool->free(element, pool->pool_data);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment