Commit 73956fc0 authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Ingo Molnar
Browse files

membarrier: Fix RCU locking bug caused by faulty merge

The following commit:


 ("sched/membarrier: Fix p->mm->membarrier_state racy load")

got fat fingered by me when merging it with other patches. It meant to move
the RCU section out of the for loop but ended up doing it partially, leaving
a superfluous rcu_read_lock() inside, causing havok.
Reported-by: default avatarIngo Molnar <>
Signed-off-by: default avatarPeter Zijlstra (Intel) <>
Cc: Borislav Petkov <>
Cc: Chris Metcalf <>
Cc: Christoph Lameter <>
Cc: Eric W. Biederman <>
Cc: Kirill Tkhai <>
Cc: Linus Torvalds <>
Cc: Mathieu Desnoyers <>
Cc: Mike Galbraith <>
Cc: Oleg Nesterov <>
Cc: Paul E. McKenney <>
Cc: Peter Zijlstra <>
Cc: Russell King - ARM Linux admin <>
Cc: Thomas Gleixner <>
Fixes: 227a4aad ("sched/membarrier: Fix p->mm->membarrier_state racy load")

Signed-off-by: default avatarIngo Molnar <>
parent 54ecb8f7
......@@ -174,7 +174,6 @@ static int membarrier_private_expedited(int flags)
if (cpu == raw_smp_processor_id())
p = rcu_dereference(cpu_rq(cpu)->curr);
if (p && p->mm == mm)
__cpumask_set_cpu(cpu, tmpmask);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment