Commit f8a18d61 authored by James Clark's avatar James Clark
Browse files

perf cs-etm: Improve Coresight zero timestamp warning



Only show the warning if the user hasn't already set timeless mode.
Also improve the text because there was ambiguity around the
meaning of '...'.
Suggested-by: Leo Yan's avatarLeo Yan <leo.yan@linaro.org>
Signed-off-by: James Clark's avatarJames Clark <james.clark@arm.com>
parent b213c3a3
......@@ -309,8 +309,10 @@ cs_etm_decoder__do_hard_timestamp(struct cs_etm_queue *etmq,
* underflow.
*/
packet_queue->cs_timestamp = 0;
WARN_ONCE(true, "Zero Coresight timestamp found at Idx:%" OCSD_TRC_IDX_STR
". Decoding may be improved with --itrace=Z...\n", indx);
WARN_ONCE(!cs_etm__etmq_is_timeless(etmq),
"Zero Coresight timestamp found at Idx:%" OCSD_TRC_IDX_STR
". Decoding may be improved by prepending 'Z' to your current --itrace arguments.\n",
indx);
} else if (packet_queue->instr_count > elem->timestamp) {
/*
* Sanity check that the elem->timestamp - packet_queue->instr_count would not
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment