Skip to content
  • Arnd Bergmann's avatar
    Kbuild: use -fshort-wchar globally · 8c97023c
    Arnd Bergmann authored
    Commit 971a69db ("Xen: don't warn about 2-byte wchar_t in efi")
    added the --no-wchar-size-warning to the Makefile to avoid this
    harmless warning:
    
    arm-linux-gnueabi-ld: warning: drivers/xen/efi.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail
    
    Changing kbuild to use thin archives instead of recursive linking
    unfortunately brings the same warning back during the final link.
    
    The kernel does not use wchar_t string literals at this point, and
    xen does not use wchar_t at all (only efi_char16_t), so the flag
    has no effect, but as pointed out by Jan Beulich, adding a wchar_t
    string literal would be bad here.
    
    Since wchar_t is always defined as u16, independent of the toolchain
    default, always passing -fshort-wchar is correct and lets us
    remove the Xen specific hack along with fixing the warning.
    
    Link: https://patchwork.kernel.org/patch/9275217/
    Fixes: 971a69db
    
     ("Xen: don't warn about 2-byte wchar_t in efi")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarDavid Vrabel <david.vrabel@citrix.com>
    Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
    8c97023c