Possible Bug on find_energy_efficient_cpu.

Hi guys!

I was studying your code about EAS on CFS and I saw something that made me thinking.

In your code in fair.c ::find_energy_efficient_cpu() at line 6293 there is this instruction:

base_energy_pd = compute_energy(p, -1, pd);

So in base_energy_pd there is the energy consumed by the core without p.

After this there is at line 6317

prev_delta = compute_energy(p, prev_cpu, pd);

That compute the energy with p on core prev_cpu.

My question is: Is safe do this operation without checking that OPP is the same? Could p on prev_cpu rising the OPP of the entire pd?

Thanks a lot!

mentioned in commit 9c2876d5

mentioned in commit 3a02764c

mentioned in commit c087e948

mentioned in commit 704adfb5

mentioned in commit ch-linux-perf@b853fd36

mentioned in commit ch-linux-perf@e9c7d656

mentioned in commit ch-linux-perf@e533dbe9

mentioned in commit ee8a9600

mentioned in commit aba5daeb

mentioned in commit 57f0ff05

mentioned in commit 4f74f187

mentioned in commit 56ee254d

By Ghost User on 2022-03-01T00:10:21

mentioned in commit 74c42e1b

By Ghost User on 2022-03-01T00:10:22

mentioned in commit c32cef58

By Ghost User on 2022-03-01T00:13:54

mentioned in commit a80ced6e

mentioned in commit 24d7275c

mentioned in commit 0764db9b

mentioned in commit f9b141f9

mentioned in commit 23c2d497

mentioned in commit 94e81006

mentioned in commit 51a6fa07

mentioned in commit 4b335e1e

mentioned in commit a8616d2d

mentioned in commit 9cc205e3

mentioned in commit 550b33cf

mentioned in commit 50e63dd8

mentioned in commit ab57bc6f

mentioned in commit 1c6b3006

mentioned in commit a4ab173f

mentioned in commit a89ff5f5

mentioned in commit e65a6897

mentioned in commit b30a768c

mentioned in commit 3525911f

mentioned in commit 462a8e08

mentioned in commit d7284bf8

mentioned in commit fcde88af

mentioned in commit 902160cd

mentioned in commit d6a04437

mentioned in commit 6eaf41e8

mentioned in commit 7f7cfcb6

mentioned in commit d40ae85e

mentioned in commit 675a15f4

mentioned in commit 8a96c028

closed

mentioned in commit 41f10081

mentioned in commit 41f10081

mentioned in commit c8d430db

mentioned in commit 73f35080

mentioned in commit 796787c9

mentioned in commit 47b0c2e4