Commit 592025a0 authored by Jacob Keller's avatar Jacob Keller Committed by David S. Miller
Browse files

renesas: reject unsupported external timestamp flags

Fix the renesas PTP support to explicitly reject any future flags that
get added to the external timestamp request ioctl.

In order to maintain currently functioning code, this patch accepts all
three current flags. This is because the PTP_RISING_EDGE and
PTP_FALLING_EDGE flags have unclear semantics and each driver seems to
have interpreted them slightly differently.

Cc: Sergei Shtylyov <>
Signed-off-by: default avatarJacob Keller <>
Reviewed-by: default avatarRichard Cochran <>
Reviewed-by: default avatarSergei Shtylyov <>
Signed-off-by: default avatarDavid S. Miller <>
parent 2e0645a0
......@@ -182,6 +182,12 @@ static int ravb_ptp_extts(struct ptp_clock_info *ptp,
struct net_device *ndev = priv->ndev;
unsigned long flags;
/* Reject requests with unsupported flags */
if (req->flags & ~(PTP_ENABLE_FEATURE |
if (req->index)
return -EINVAL;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment