Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • linux-vf linux-vf
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • linux-arm
  • linux-vflinux-vf
  • Repository
Switch branch/tag
  • linux-vf
  • arch
  • x86
  • boot
  • compressed
  • misc.h
Find file BlameHistoryPermalink
  • Borislav Petkov's avatar
    x86/boot: Fix cmdline_find_option() prototype visibility · 82f9ed3a
    Borislav Petkov authored Feb 05, 2019
      ac09c5f4 ("x86/boot: Build the command line parsing code unconditionally")
    
    enabled building the command line parsing code unconditionally but it
    forgot to remove the respective ifdeffery around the prototypes in the
    misc.h header, leading to
    
      arch/x86/boot/compressed/acpi.c: In function ‘get_acpi_rsdp’:
      arch/x86/boot/compressed/acpi.c:37:8: warning: implicit declaration of function \
    	  ‘cmdline_find_option’ [-Wimplicit-function-declaration]
        ret = cmdline_find_option("acpi_rsdp", val, MAX_ADDR_LEN);
              ^~~~~~~~~~~~~~~~~~~
    
    for configs where neither CONFIG_EARLY_PRINTK nor CONFIG_RANDOMIZE_BASE
    was defined.
    
    Drop the ifdeffery in the header too.
    
    Fixes: ac09c5f4
    
     ("x86/boot: Build the command line parsing code unconditionally")
    Reported-by: default avatarkbuild test robot <lkp@intel.com>
    Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
    Cc: Chao Fan <fanc.fnst@cn.fujitsu.com>
    Cc: x86@kernel.org
    Link: https://lkml.kernel.org/r/5c51daf0.83pQEkvDZILqoSYW%lkp@intel.com
    Link: https://lkml.kernel.org/r/20190205131352.GA27396@zn.tnic
    82f9ed3a