Commit 67b7ebe0 authored by Amerigo Wang's avatar Amerigo Wang Committed by Sam Ravnborg
Browse files

kbuild/headers_check: refine extern check



'extern' checking information is not clear, refine it.
Plus, fix a comment.

Signed-off-by: default avatarWANG Cong <amwang@redhat.com>
[sam: redid the extern error message]
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
parent 7211b8b9
......@@ -2,7 +2,7 @@
#
# headers_check.pl execute a number of trivial consistency checks
#
# Usage: headers_check.pl dir [files...]
# Usage: headers_check.pl dir arch [files...]
# dir: dir to look for included files
# arch: architecture
# files: list of files to check
......@@ -37,7 +37,7 @@ foreach my $file (@files) {
&check_include();
&check_asm_types();
&check_sizetypes();
&check_prototypes();
&check_declarations();
# Dropped for now. Too much noise &check_config();
}
close FH;
......@@ -61,10 +61,12 @@ sub check_include
}
}
sub check_prototypes
sub check_declarations
{
if ($line =~ m/^\s*extern\b/) {
printf STDERR "$filename:$lineno: extern's make no sense in userspace\n";
if ($line =~m/^\s*extern\b/) {
printf STDERR "$filename:$lineno: " .
"userspace cannot call function or variable " .
"defined in the kernel\n";
}
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment