Skip to content
  • Arnd Bergmann's avatar
    i40iw: avoid potential uninitialized variable use · 2fe78571
    Arnd Bergmann authored
    
    
    gcc finds that the i40iw_make_cm_node() function in the recently added
    i40iw driver uses an uninitilized variable as an index into an array
    if CONFIG_IPV6 is disabled and the driver uses IPv6 mode:
    
    drivers/infiniband/hw/i40iw/i40iw_cm.c: In function 'i40iw_make_cm_node':
    drivers/infiniband/hw/i40iw/i40iw_cm.c:2206:52: error: 'arpindex' may be used uninitialized in this function [-Werror=maybe-uninitialized]
      ether_addr_copy(cm_node->rem_mac, iwdev->arp_table[arpindex].mac_addr);
    
    As far as I can tell, this code path can not be used because the ipv4
    variable is always set with CONFIG_IPV6 is disabled, but it's better
    to be sure and prevent the undefined behavior, as well as shut up
    that warning in a proper way.
    
    This adds an 'else' clause for the case we get the warning about,
    causing the function to return an error in a controlled way.
    To avoid adding extra mess with combined io()/#ifdef clauses,
    I'm also converting the existing #ifdef into a more readable
    if(IS_ENABLED()) check.
    
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Fixes: f27b4746
    
     ("i40iw: add connection management code")
    Acked-by: default avatarMustafa Ismail <Mustafa.ismail@intel.com>
    Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
    2fe78571