• Eric Dumazet's avatar
    net: revert 8728c544 ("net: dev_pick_tx() fix") · 702821f4
    Eric Dumazet authored
    commit 8728c544 ("net: dev_pick_tx() fix") and commit
    b6fe83e9 ("bonding: refine IFF_XMIT_DST_RELEASE capability")
    are quite incompatible : Queue selection is disabled because skb
    dst was dropped before entering bonding device.
    This causes major performance regression, mainly because TCP packets
    for a given flow can be sent to multiple queues.
    This is particularly visible when using the new FQ packet scheduler
    with MQ + FQ setup on the slaves.
    We can safely revert the first commit now that 416186fb
    ("net: Split core bits of netdev_pick_tx into __netdev_pick_tx")
    properly caps the queue_index.
    Reported-by: default avatarXi Wang <xii@google.com>
    Diagnosed-by: default avatarXi Wang <xii@google.com>
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Cc: Tom Herbert <therbert@google.com>
    Cc: Alexander Duyck <alexander.h.duyck@intel.com>
    Cc: Denys Fedorysychenko <nuclearcat@nuclearcat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>