Skip to content
  • Cong Wang's avatar
    vlan: adjust vlan_set_encap_proto() for its callers · da8c8724
    Cong Wang authored
    
    
    There are two places to call vlan_set_encap_proto():
    vlan_untag() and __pop_vlan_tci().
    
    vlan_untag() assumes skb->data points after mac addr, otherwise
    the following code
    
            vhdr = (struct vlan_hdr *) skb->data;
            vlan_tci = ntohs(vhdr->h_vlan_TCI);
            __vlan_hwaccel_put_tag(skb, vlan_tci);
    
            skb_pull_rcsum(skb, VLAN_HLEN);
    
    won't be correct. But __pop_vlan_tci() assumes points _before_
    mac addr.
    
    In vlan_set_encap_proto(), it looks for some magic L2 value
    after mac addr:
    
            rawp = skb->data;
            if (*(unsigned short *) rawp == 0xFFFF)
    	...
    
    Therefore __pop_vlan_tci() is obviously wrong.
    
    A quick fix is avoiding using skb->data in vlan_set_encap_proto(),
    use 'vhdr+1' is always correct in both cases.
    
    Cc: David S. Miller <davem@davemloft.net>
    Cc: Jesse Gross <jesse@nicira.com>
    Signed-off-by: default avatarCong Wang <amwang@redhat.com>
    Acked-by: default avatarJesse Gross <jesse@nicira.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    da8c8724