Commit acc18c14 authored by Girish K S's avatar Girish K S Committed by David S. Miller
Browse files

net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe



Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver.
Signed-off-by: default avatarGirish K S <ks.giri@samsung.com>
Neatening-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarByungho An <bh74.an@samsung.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1edb9ca6
...@@ -118,6 +118,33 @@ struct sxgbe_mtl_ops; ...@@ -118,6 +118,33 @@ struct sxgbe_mtl_ops;
#define RX_PTP_SIGNAL 0x0A #define RX_PTP_SIGNAL 0x0A
#define RX_PTP_RESV_MSG 0x0F #define RX_PTP_RESV_MSG 0x0F
/* EEE-LPI mode flags*/
#define TX_ENTRY_LPI_MODE 0x10
#define TX_EXIT_LPI_MODE 0x20
#define RX_ENTRY_LPI_MODE 0x40
#define RX_EXIT_LPI_MODE 0x80
/* EEE-LPI Interrupt status flag */
#define LPI_INT_STATUS BIT(5)
/* EEE-LPI Default timer values */
#define LPI_LINK_STATUS_TIMER 0x3E8
#define LPI_MAC_WAIT_TIMER 0x00
/* EEE-LPI Control and status definitions */
#define LPI_CTRL_STATUS_TXA BIT(19)
#define LPI_CTRL_STATUS_PLSDIS BIT(18)
#define LPI_CTRL_STATUS_PLS BIT(17)
#define LPI_CTRL_STATUS_LPIEN BIT(16)
#define LPI_CTRL_STATUS_TXRSTP BIT(11)
#define LPI_CTRL_STATUS_RXRSTP BIT(10)
#define LPI_CTRL_STATUS_RLPIST BIT(9)
#define LPI_CTRL_STATUS_TLPIST BIT(8)
#define LPI_CTRL_STATUS_RLPIEX BIT(3)
#define LPI_CTRL_STATUS_RLPIEN BIT(2)
#define LPI_CTRL_STATUS_TLPIEX BIT(1)
#define LPI_CTRL_STATUS_TLPIEN BIT(0)
enum dma_irq_status { enum dma_irq_status {
tx_hard_error = BIT(0), tx_hard_error = BIT(0),
tx_bump_tc = BIT(1), tx_bump_tc = BIT(1),
...@@ -202,6 +229,13 @@ struct sxgbe_extra_stats { ...@@ -202,6 +229,13 @@ struct sxgbe_extra_stats {
unsigned long rx_buffer_access_err; unsigned long rx_buffer_access_err;
unsigned long rx_data_transfer_err; unsigned long rx_data_transfer_err;
/* EEE-LPI stats */
unsigned long tx_lpi_entry_n;
unsigned long tx_lpi_exit_n;
unsigned long rx_lpi_entry_n;
unsigned long rx_lpi_exit_n;
unsigned long eee_wakeup_error_n;
/* RX specific */ /* RX specific */
/* L2 error */ /* L2 error */
unsigned long rx_code_gmii_err; unsigned long rx_code_gmii_err;
...@@ -299,6 +333,13 @@ struct sxgbe_core_ops { ...@@ -299,6 +333,13 @@ struct sxgbe_core_ops {
unsigned char feature_index); unsigned char feature_index);
/* adjust SXGBE speed */ /* adjust SXGBE speed */
void (*set_speed)(void __iomem *ioaddr, unsigned char speed); void (*set_speed)(void __iomem *ioaddr, unsigned char speed);
/* EEE-LPI specific operations */
void (*set_eee_mode)(void __iomem *ioaddr);
void (*reset_eee_mode)(void __iomem *ioaddr);
void (*set_eee_timer)(void __iomem *ioaddr, const int ls,
const int tw);
void (*set_eee_pls)(void __iomem *ioaddr, const int link);
}; };
const struct sxgbe_core_ops *sxgbe_get_core_ops(void); const struct sxgbe_core_ops *sxgbe_get_core_ops(void);
...@@ -354,6 +395,8 @@ struct sxgbe_hw_features { ...@@ -354,6 +395,8 @@ struct sxgbe_hw_features {
/* IEEE 1588-2008 */ /* IEEE 1588-2008 */
unsigned int atime_stamp; unsigned int atime_stamp;
unsigned int eee;
unsigned int tx_csum_offload; unsigned int tx_csum_offload;
unsigned int rx_csum_offload; unsigned int rx_csum_offload;
unsigned int multi_macaddr; unsigned int multi_macaddr;
...@@ -437,6 +480,13 @@ struct sxgbe_priv_data { ...@@ -437,6 +480,13 @@ struct sxgbe_priv_data {
/* tc control */ /* tc control */
int tx_tc; int tx_tc;
int rx_tc; int rx_tc;
/* EEE-LPI specific members */
struct timer_list eee_ctrl_timer;
bool tx_path_in_lpi_mode;
int lpi_irq;
int eee_enabled;
int eee_active;
int tx_lpi_timer;
}; };
/* Function prototypes */ /* Function prototypes */
...@@ -459,4 +509,7 @@ int sxgbe_restore(struct net_device *ndev); ...@@ -459,4 +509,7 @@ int sxgbe_restore(struct net_device *ndev);
const struct sxgbe_mtl_ops *sxgbe_get_mtl_ops(void); const struct sxgbe_mtl_ops *sxgbe_get_mtl_ops(void);
void sxgbe_disable_eee_mode(struct sxgbe_priv_data * const priv);
bool sxgbe_eee_init(struct sxgbe_priv_data * const priv);
#endif /* __SXGBE_COMMON_H__ */ #endif /* __SXGBE_COMMON_H__ */
...@@ -48,11 +48,38 @@ static void sxgbe_core_dump_regs(void __iomem *ioaddr) ...@@ -48,11 +48,38 @@ static void sxgbe_core_dump_regs(void __iomem *ioaddr)
{ {
} }
static int sxgbe_get_lpi_status(void __iomem *ioaddr, const u32 irq_status)
{
int status = 0;
int lpi_status;
/* Reading this register shall clear all the LPI status bits */
lpi_status = readl(ioaddr + SXGBE_CORE_LPI_CTRL_STATUS);
if (lpi_status & LPI_CTRL_STATUS_TLPIEN)
status |= TX_ENTRY_LPI_MODE;
if (lpi_status & LPI_CTRL_STATUS_TLPIEX)
status |= TX_EXIT_LPI_MODE;
if (lpi_status & LPI_CTRL_STATUS_RLPIEN)
status |= RX_ENTRY_LPI_MODE;
if (lpi_status & LPI_CTRL_STATUS_RLPIEX)
status |= RX_EXIT_LPI_MODE;
return status;
}
/* Handle extra events on specific interrupts hw dependent */ /* Handle extra events on specific interrupts hw dependent */
static int sxgbe_core_host_irq_status(void __iomem *ioaddr, static int sxgbe_core_host_irq_status(void __iomem *ioaddr,
struct sxgbe_extra_stats *x) struct sxgbe_extra_stats *x)
{ {
return 0; int irq_status, status = 0;
irq_status = readl(ioaddr + SXGBE_CORE_INT_STATUS_REG);
if (unlikely(irq_status & LPI_INT_STATUS))
status |= sxgbe_get_lpi_status(ioaddr, irq_status);
return status;
} }
/* Set power management mode (e.g. magic frame) */ /* Set power management mode (e.g. magic frame) */
...@@ -138,6 +165,59 @@ static void sxgbe_core_set_speed(void __iomem *ioaddr, unsigned char speed) ...@@ -138,6 +165,59 @@ static void sxgbe_core_set_speed(void __iomem *ioaddr, unsigned char speed)
writel(tx_cfg, ioaddr + SXGBE_CORE_TX_CONFIG_REG); writel(tx_cfg, ioaddr + SXGBE_CORE_TX_CONFIG_REG);
} }
static void sxgbe_set_eee_mode(void __iomem *ioaddr)
{
u32 ctrl;
/* Enable the LPI mode for transmit path with Tx automate bit set.
* When Tx Automate bit is set, MAC internally handles the entry
* to LPI mode after all outstanding and pending packets are
* transmitted.
*/
ctrl = readl(ioaddr + SXGBE_CORE_LPI_CTRL_STATUS);
ctrl |= LPI_CTRL_STATUS_LPIEN | LPI_CTRL_STATUS_TXA;
writel(ctrl, ioaddr + SXGBE_CORE_LPI_CTRL_STATUS);
}
static void sxgbe_reset_eee_mode(void __iomem *ioaddr)
{
u32 ctrl;
ctrl = readl(ioaddr + SXGBE_CORE_LPI_CTRL_STATUS);
ctrl &= ~(LPI_CTRL_STATUS_LPIEN | LPI_CTRL_STATUS_TXA);
writel(ctrl, ioaddr + SXGBE_CORE_LPI_CTRL_STATUS);
}
static void sxgbe_set_eee_pls(void __iomem *ioaddr, const int link)
{
u32 ctrl;
ctrl = readl(ioaddr + SXGBE_CORE_LPI_CTRL_STATUS);
/* If the PHY link status is UP then set PLS */
if (link)
ctrl |= LPI_CTRL_STATUS_PLS;
else
ctrl &= ~LPI_CTRL_STATUS_PLS;
writel(ctrl, ioaddr + SXGBE_CORE_LPI_CTRL_STATUS);
}
static void sxgbe_set_eee_timer(void __iomem *ioaddr,
const int ls, const int tw)
{
int value = ((tw & 0xffff)) | ((ls & 0x7ff) << 16);
/* Program the timers in the LPI timer control register:
* LS: minimum time (ms) for which the link
* status from PHY should be ok before transmitting
* the LPI pattern.
* TW: minimum time (us) for which the core waits
* after it has stopped transmitting the LPI pattern.
*/
writel(value, ioaddr + SXGBE_CORE_LPI_TIMER_CTRL);
}
const struct sxgbe_core_ops core_ops = { const struct sxgbe_core_ops core_ops = {
.core_init = sxgbe_core_init, .core_init = sxgbe_core_init,
.dump_regs = sxgbe_core_dump_regs, .dump_regs = sxgbe_core_dump_regs,
...@@ -150,6 +230,10 @@ const struct sxgbe_core_ops core_ops = { ...@@ -150,6 +230,10 @@ const struct sxgbe_core_ops core_ops = {
.get_controller_version = sxgbe_get_controller_version, .get_controller_version = sxgbe_get_controller_version,
.get_hw_feature = sxgbe_get_hw_feature, .get_hw_feature = sxgbe_get_hw_feature,
.set_speed = sxgbe_core_set_speed, .set_speed = sxgbe_core_set_speed,
.set_eee_mode = sxgbe_set_eee_mode,
.reset_eee_mode = sxgbe_reset_eee_mode,
.set_eee_timer = sxgbe_set_eee_timer,
.set_eee_pls = sxgbe_set_eee_pls,
}; };
const struct sxgbe_core_ops *sxgbe_get_core_ops(void) const struct sxgbe_core_ops *sxgbe_get_core_ops(void)
......
...@@ -32,10 +32,57 @@ struct sxgbe_stats { ...@@ -32,10 +32,57 @@ struct sxgbe_stats {
} }
static const struct sxgbe_stats sxgbe_gstrings_stats[] = { static const struct sxgbe_stats sxgbe_gstrings_stats[] = {
SXGBE_STAT(tx_lpi_entry_n),
SXGBE_STAT(tx_lpi_exit_n),
SXGBE_STAT(rx_lpi_entry_n),
SXGBE_STAT(rx_lpi_exit_n),
SXGBE_STAT(eee_wakeup_error_n),
}; };
#define SXGBE_STATS_LEN ARRAY_SIZE(sxgbe_gstrings_stats) #define SXGBE_STATS_LEN ARRAY_SIZE(sxgbe_gstrings_stats)
static int sxgbe_get_eee(struct net_device *dev,
struct ethtool_eee *edata)
{
struct sxgbe_priv_data *priv = netdev_priv(dev);
if (!priv->hw_cap.eee)
return -EOPNOTSUPP;
edata->eee_enabled = priv->eee_enabled;
edata->eee_active = priv->eee_active;
edata->tx_lpi_timer = priv->tx_lpi_timer;
return phy_ethtool_get_eee(priv->phydev, edata);
}
static int sxgbe_set_eee(struct net_device *dev,
struct ethtool_eee *edata)
{
struct sxgbe_priv_data *priv = netdev_priv(dev);
priv->eee_enabled = edata->eee_enabled;
if (!priv->eee_enabled) {
sxgbe_disable_eee_mode(priv);
} else {
/* We are asking for enabling the EEE but it is safe
* to verify all by invoking the eee_init function.
* In case of failure it will return an error.
*/
priv->eee_enabled = sxgbe_eee_init(priv);
if (!priv->eee_enabled)
return -EOPNOTSUPP;
/* Do not change tx_lpi_timer in case of failure */
priv->tx_lpi_timer = edata->tx_lpi_timer;
}
return phy_ethtool_set_eee(priv->phydev, edata);
}
static const struct ethtool_ops sxgbe_ethtool_ops = { static const struct ethtool_ops sxgbe_ethtool_ops = {
.get_eee = sxgbe_get_eee,
.set_eee = sxgbe_set_eee,
}; };
void sxgbe_set_ethtool_ops(struct net_device *netdev) void sxgbe_set_ethtool_ops(struct net_device *netdev)
......
...@@ -55,6 +55,9 @@ ...@@ -55,6 +55,9 @@
#define SXGBE_DEFAULT_LPI_TIMER 1000 #define SXGBE_DEFAULT_LPI_TIMER 1000
static int debug = -1; static int debug = -1;
static int eee_timer = SXGBE_DEFAULT_LPI_TIMER;
module_param(eee_timer, int, S_IRUGO | S_IWUSR);
module_param(debug, int, S_IRUGO | S_IWUSR); module_param(debug, int, S_IRUGO | S_IWUSR);
static const u32 default_msg_level = (NETIF_MSG_DRV | NETIF_MSG_PROBE | static const u32 default_msg_level = (NETIF_MSG_DRV | NETIF_MSG_PROBE |
...@@ -67,6 +70,97 @@ static irqreturn_t sxgbe_rx_interrupt(int irq, void *dev_id); ...@@ -67,6 +70,97 @@ static irqreturn_t sxgbe_rx_interrupt(int irq, void *dev_id);
#define SXGBE_COAL_TIMER(x) (jiffies + usecs_to_jiffies(x)) #define SXGBE_COAL_TIMER(x) (jiffies + usecs_to_jiffies(x))
#define SXGBE_LPI_TIMER(x) (jiffies + msecs_to_jiffies(x))
/**
* sxgbe_verify_args - verify the driver parameters.
* Description: it verifies if some wrong parameter is passed to the driver.
* Note that wrong parameters are replaced with the default values.
*/
static void sxgbe_verify_args(void)
{
if (unlikely(eee_timer < 0))
eee_timer = SXGBE_DEFAULT_LPI_TIMER;
}
static void sxgbe_enable_eee_mode(const struct sxgbe_priv_data *priv)
{
/* Check and enter in LPI mode */
if (!priv->tx_path_in_lpi_mode)
priv->hw->mac->set_eee_mode(priv->ioaddr);
}
void sxgbe_disable_eee_mode(struct sxgbe_priv_data * const priv)
{
/* Exit and disable EEE in case of we are are in LPI state. */
priv->hw->mac->reset_eee_mode(priv->ioaddr);
del_timer_sync(&priv->eee_ctrl_timer);
priv->tx_path_in_lpi_mode = false;
}
/**
* sxgbe_eee_ctrl_timer
* @arg : data hook
* Description:
* If there is no data transfer and if we are not in LPI state,
* then MAC Transmitter can be moved to LPI state.
*/
static void sxgbe_eee_ctrl_timer(unsigned long arg)
{
struct sxgbe_priv_data *priv = (struct sxgbe_priv_data *)arg;
sxgbe_enable_eee_mode(priv);
mod_timer(&priv->eee_ctrl_timer, SXGBE_LPI_TIMER(eee_timer));
}
/**
* sxgbe_eee_init
* @priv: private device pointer
* Description:
* If the EEE support has been enabled while configuring the driver,
* if the GMAC actually supports the EEE (from the HW cap reg) and the
* phy can also manage EEE, so enable the LPI state and start the timer
* to verify if the tx path can enter in LPI state.
*/
bool sxgbe_eee_init(struct sxgbe_priv_data * const priv)
{
bool ret = false;
/* MAC core supports the EEE feature. */
if (priv->hw_cap.eee) {
/* Check if the PHY supports EEE */
if (phy_init_eee(priv->phydev, 1))
return false;
priv->eee_active = 1;
init_timer(&priv->eee_ctrl_timer);
priv->eee_ctrl_timer.function = sxgbe_eee_ctrl_timer;
priv->eee_ctrl_timer.data = (unsigned long)priv;
priv->eee_ctrl_timer.expires = SXGBE_LPI_TIMER(eee_timer);
add_timer(&priv->eee_ctrl_timer);
priv->hw->mac->set_eee_timer(priv->ioaddr,
SXGBE_DEFAULT_LPI_TIMER,
priv->tx_lpi_timer);
pr_info("Energy-Efficient Ethernet initialized\n");
ret = true;
}
return ret;
}
static void sxgbe_eee_adjust(const struct sxgbe_priv_data *priv)
{
/* When the EEE has been already initialised we have to
* modify the PLS bit in the LPI ctrl & status reg according
* to the PHY link status. For this reason.
*/
if (priv->eee_enabled)
priv->hw->mac->set_eee_pls(priv->ioaddr, priv->phydev->link);
}
/** /**
* sxgbe_clk_csr_set - dynamically set the MDC clock * sxgbe_clk_csr_set - dynamically set the MDC clock
* @priv: driver private structure * @priv: driver private structure
...@@ -156,6 +250,9 @@ static void sxgbe_adjust_link(struct net_device *dev) ...@@ -156,6 +250,9 @@ static void sxgbe_adjust_link(struct net_device *dev)
if (new_state & netif_msg_link(priv)) if (new_state & netif_msg_link(priv))
phy_print_status(phydev); phy_print_status(phydev);
/* Alter the MAC settings for EEE */
sxgbe_eee_adjust(priv);
} }
/** /**
...@@ -676,7 +773,7 @@ static void sxgbe_tx_queue_clean(struct sxgbe_tx_queue *tqueue) ...@@ -676,7 +773,7 @@ static void sxgbe_tx_queue_clean(struct sxgbe_tx_queue *tqueue)
* @priv: driver private structure * @priv: driver private structure
* Description: it reclaims resources after transmission completes. * Description: it reclaims resources after transmission completes.
*/ */
static void sxgbe_tx_all_clean(struct sxgbe_priv_data *priv) static void sxgbe_tx_all_clean(struct sxgbe_priv_data * const priv)
{ {
u8 queue_num; u8 queue_num;
...@@ -685,6 +782,11 @@ static void sxgbe_tx_all_clean(struct sxgbe_priv_data *priv) ...@@ -685,6 +782,11 @@ static void sxgbe_tx_all_clean(struct sxgbe_priv_data *priv)
sxgbe_tx_queue_clean(tqueue); sxgbe_tx_queue_clean(tqueue);
} }
if ((priv->eee_enabled) && (!priv->tx_path_in_lpi_mode)) {
sxgbe_enable_eee_mode(priv);
mod_timer(&priv->eee_ctrl_timer, SXGBE_LPI_TIMER(eee_timer));
}
} }
/** /**
...@@ -766,6 +868,7 @@ static int sxgbe_get_hw_features(struct sxgbe_priv_data * const priv) ...@@ -766,6 +868,7 @@ static int sxgbe_get_hw_features(struct sxgbe_priv_data * const priv)
features->multi_macaddr = SXGBE_HW_FEAT_MACADDR_COUNT(rval); features->multi_macaddr = SXGBE_HW_FEAT_MACADDR_COUNT(rval);
features->tstamp_srcselect = SXGBE_HW_FEAT_TSTMAP_SRC(rval); features->tstamp_srcselect = SXGBE_HW_FEAT_TSTMAP_SRC(rval);
features->sa_vlan_insert = SXGBE_HW_FEAT_SRCADDR_VLAN(rval); features->sa_vlan_insert = SXGBE_HW_FEAT_SRCADDR_VLAN(rval);
features->eee = SXGBE_HW_FEAT_EEE(rval);
} }
/* Read First Capability Register CAP[1] */ /* Read First Capability Register CAP[1] */
...@@ -983,6 +1086,20 @@ static int sxgbe_open(struct net_device *dev) ...@@ -983,6 +1086,20 @@ static int sxgbe_open(struct net_device *dev)
goto init_error; goto init_error;
} }
/* If the LPI irq is different from the mac irq
* register a dedicated handler
*/
if (priv->lpi_irq != dev->irq) {
ret = devm_request_irq(priv->device, priv->lpi_irq,
sxgbe_common_interrupt,
IRQF_SHARED, dev->name, dev);
if (unlikely(ret < 0)) {
netdev_err(dev, "%s: ERROR: allocating the LPI IRQ %d (%d)\n",
__func__, priv->lpi_irq, ret);
goto init_error;
}
}
/* Request TX DMA irq lines */ /* Request TX DMA irq lines */
SXGBE_FOR_EACH_QUEUE(SXGBE_TX_QUEUES, queue_num) { SXGBE_FOR_EACH_QUEUE(SXGBE_TX_QUEUES, queue_num) {
ret = devm_request_irq(priv->device, ret = devm_request_irq(priv->device,
...@@ -1038,6 +1155,9 @@ static int sxgbe_open(struct net_device *dev) ...@@ -1038,6 +1155,9 @@ static int sxgbe_open(struct net_device *dev)
priv->hw->dma->rx_watchdog(priv->ioaddr, SXGBE_MAX_DMA_RIWT); priv->hw->dma->rx_watchdog(priv->ioaddr, SXGBE_MAX_DMA_RIWT);
} }
priv->tx_lpi_timer = SXGBE_DEFAULT_LPI_TIMER;
priv->eee_enabled = sxgbe_eee_init(priv);
napi_enable(&priv->napi); napi_enable(&priv->napi);
netif_start_queue(dev); netif_start_queue(dev);
...@@ -1063,6 +1183,9 @@ static int sxgbe_release(struct net_device *dev) ...@@ -1063,6 +1183,9 @@ static int sxgbe_release(struct net_device *dev)
{ {
struct sxgbe_priv_data *priv = netdev_priv(dev); struct sxgbe_priv_data *priv = netdev_priv(dev);
if (priv->eee_enabled)
del_timer_sync(&priv->eee_ctrl_timer);
/* Stop and disconnect the PHY */ /* Stop and disconnect the PHY */
if (priv->phydev) { if (priv->phydev) {
phy_stop(priv->phydev); phy_stop(priv->phydev);
...@@ -1123,6 +1246,9 @@ static netdev_tx_t sxgbe_xmit(struct sk_buff *skb, struct net_device *dev) ...@@ -1123,6 +1246,9 @@ static netdev_tx_t sxgbe_xmit(struct sk_buff *skb, struct net_device *dev)
/* get the spinlock */ /* get the spinlock */
spin_lock(&tqueue->tx_lock); spin_lock(&tqueue->tx_lock);
if (priv->tx_path_in_lpi_mode)
sxgbe_disable_eee_mode(priv);
if (unlikely(sxgbe_tx_avail(tqueue, tx_rsize) < nr_frags + 1)) { if (unlikely(sxgbe_tx_avail(tqueue, tx_rsize) < nr_frags + 1)) {
if (!netif_tx_queue_stopped(dev_txq)) { if (!netif_tx_queue_stopped(dev_txq)) {
netif_tx_stop_queue(dev_txq); netif_tx_stop_queue(dev_txq);
...@@ -1380,6 +1506,25 @@ static void sxgbe_tx_timeout(struct net_device *dev) ...@@ -1380,6 +1506,25 @@ static void sxgbe_tx_timeout(struct net_device *dev)
*/ */
static irqreturn_t sxgbe_common_interrupt(int irq, void *dev_id) static irqreturn_t sxgbe_common_interrupt(int irq, void *dev_id)
{ {
struct net_device *netdev = (struct net_device *)dev_id;
struct sxgbe_priv_data *priv = netdev_priv(netdev);
int status;
status = priv->hw->mac->host_irq_status(priv->ioaddr, &priv->xstats);
/* For LPI we need to save the tx status */
if (status & TX_ENTRY_LPI_MODE) {
priv->xstats.tx_lpi_entry_n++;
priv->tx_path_in_lpi_mode = true;
}
if (status & TX_EXIT_LPI_MODE) {
priv->xstats.tx_lpi_exit_n++;
priv->tx_path_in_lpi_mode = false;
}
if (status & RX_ENTRY_LPI_MODE)
priv->xstats.rx_lpi_entry_n++;
if (status & RX_EXIT_LPI_MODE)
priv->xstats.rx_lpi_exit_n++;
return IRQ_HANDLED; return IRQ_HANDLED;
} }
...@@ -1876,6 +2021,9 @@ struct sxgbe_priv_data *sxgbe_drv_probe(struct device *device, ...@@ -1876,6 +2021,9 @@ struct sxgbe_priv_data *sxgbe_drv_probe(struct device *device,
priv->plat = plat_dat; priv->plat = plat_dat;
priv->ioaddr = addr; priv->ioaddr = addr;
/* Verify driver arguments */
sxgbe_verify_args();
/* Init MAC and get the capabilities */ /* Init MAC and get the capabilities */
sxgbe_hw_init(priv); sxgbe_hw_init(priv);
...@@ -2032,7 +2180,21 @@ module_exit(sxgbe_exit); ...@@ -2032,7 +2180,21 @@ module_exit(sxgbe_exit);
#ifndef MODULE #ifndef MODULE
static int __init sxgbe_cmdline_opt(char *str) static int __init sxgbe_cmdline_opt(char *str)
{ {
char *opt;
if (!str || !*str)
return -EINVAL;
while ((opt = strsep(&str, ",")) != NULL) {
if (!strncmp(opt, "eee_timer:", 6)) {