- 11 Aug, 2019 1 commit
-
-
Przemyslaw Gaj authored
I need to store address and lvr value for I2C devices without static definition in DT. This allows secondary master to transmit DEFSLVS command properly. Main changes between v4 and v5: - Change in defslvs to use addr and lvr from i2c_dev_desc structure - Change in CDNS and DW drivers to use addr and lvr from i2c_dev_desc structure Signed-off-by:
Przemyslaw Gaj <pgaj@cadence.com> Signed-off-by:
Boris Brezillon <boris.brezillon@collabora.com>
-
- 20 Jun, 2019 1 commit
-
-
Vitor Soares authored
This patch add limited bus mode support for DesignWare i3c master Signed-off-by:
Vitor Soares <vitor.soares@synopsys.com> Cc: Boris Brezillon <bbrezillon@kernel.org> Cc: <linux-kernel@vger.kernel.org> Signed-off-by:
Boris Brezillon <boris.brezillon@collabora.com>
-
- 28 May, 2019 1 commit
-
-
Przemyslaw Gaj authored
This patch drops support for I2C devices with 10 bit addressing. When I2C device with 10 bit address is defined in DT, I3C master registration fails. Address space for I2C devices has been reduced and ->i2c_funcs() hook has been removed. Because this patch series dropped support for 10 bit I2C devices, support is also dropped in Cadence I3C master driver and Synopsys DesignWare I3C master driver. Signed-off-by:
Przemyslaw Gaj <pgaj@cadence.com> Signed-off-by:
Boris Brezillon <boris.brezillon@collabora.com>
-
- 10 Apr, 2019 1 commit
-
-
Vitor Soares authored
The controller was being disabled incorrectly. The correct way is to clear the DEV_CTRL_ENABLE bit. Fix this by clearing this bit. Cc: Boris Brezillon <bbrezillon@kernel.org> Cc: <stable@vger.kernel.org> Fixes: 1dd728f5 ("i3c: master: Add driver for Synopsys DesignWare IP") Signed-off-by:
Vitor Soares <vitor.soares@synopsys.com> Signed-off-by:
Boris Brezillon <boris.brezillon@collabora.com>
-
- 30 Mar, 2019 1 commit
-
-
Vitor Soares authored
Detected by CoverityScan (Event result_independent_of_operands): "(i3c_xfers + i).len > 65536" is always false regardless of the values of its operands. This occurs as the logical operand of "if" "(i2c_xfers + i).len > 65536" is always false regardless of the values of its operands. This occurs as the logical operand of "if" Signed-off-by:
Vitor Soares <vitor.soares@synopsys.com> Signed-off-by:
Boris Brezillon <boris.brezillon@collabora.com>
-
- 28 Feb, 2019 1 commit
-
-
Gustavo A. R. Silva authored
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/i3c/master/dw-i3c-master.c: In function ‘dw_i3c_master_bus_init’: drivers/i3c/master/dw-i3c-master.c:603:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (ret) ^ drivers/i3c/master/dw-i3c-master.c:605:2: note: here case I3C_BUS_MODE_PURE: ^~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by:
Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by:
Vitor Soares <vitor.soares@synopsys.com> Signed-off-by:
Boris Brezillon <boris.brezillon@collabora.com>
-
- 26 Jan, 2019 1 commit
-
-
Jisheng Zhang authored
In dw_i3c_master_irq_handler(), we already have gotten &master->xferqueue.lock, if we try to get the same lock again in dw_i3c_master_dequeue_xfer(), deadlock happens. We fix this issue by introduing dw_i3c_master_dequeue_xfer_locked() which does all what dw_i3c_master_dequeue_xfer() does without trying to lock &master->xferqueue.lock. Signed-off-by:
Jisheng Zhang <Jisheng.Zhang@synaptics.com> Acked-by: Vitor Soares <vitor.soares@synopsys.com> Signed-off-by:
Boris Brezillon <bbrezillon@kernel.org>
-
- 15 Jan, 2019 1 commit
-
-
Vitor Soares authored
This patch fix i3c_attach/reattach functions. During the i3c_attach the driver ignores the static address used for SETDASA CCC command. During the i3c_reattach the driver doesn't update master->addrs[data->index] with new address if old_dyn_addr = 0. Fixes: 1dd728f5 ("i3c: master: Add driver for Synopsys DesignWare IP") Signed-off-by:
Vitor Soares <vitor.soares@synopsys.com> Signed-off-by:
Boris Brezillon <bbrezillon@kernel.org>
-
- 05 Dec, 2018 2 commits
-
-
Colin Ian King authored
The masking operation on status is using a bitwise 'or' rather than a bitwise 'and' operator, and hence the result is always non-zero which is probably not what is intended. Fix this by using the correct operator. Detected by CoverityScan, CID#1475523 ("Wrong operator used") Fixes: 88acc98a712a ("i3c: master: Add driver for Synopsys DesignWare IP") Signed-off-by:
Colin Ian King <colin.king@canonical.com> Acked-by:
Vitor Soares <vitor.soares@synopsys.com> Signed-off-by:
Boris Brezillon <boris.brezillon@bootlin.com>
-
Vitor Soares authored
Add driver for Synopsys DesignWare I3C master IP Signed-off-by:
Vitor Soares <vitor.soares@synopsys.com> Signed-off-by:
Boris Brezillon <boris.brezillon@bootlin.com>
-