This project is mirrored from https://github.com/tianocore/edk2-test.git. Pull mirroring updated .
  1. 06 May, 2021 2 commits
  2. 19 Mar, 2021 2 commits
  3. 03 Mar, 2021 1 commit
  4. 23 Feb, 2021 1 commit
  5. 22 Feb, 2021 3 commits
  6. 03 Feb, 2021 2 commits
  7. 25 Jan, 2021 1 commit
  8. 18 Jan, 2021 3 commits
  9. 18 Dec, 2020 1 commit
  10. 11 Dec, 2020 1 commit
  11. 07 Dec, 2020 3 commits
  12. 02 Dec, 2020 3 commits
  13. 30 Nov, 2020 2 commits
  14. 24 Nov, 2020 4 commits
  15. 12 Nov, 2020 1 commit
  16. 23 Sep, 2020 1 commit
  17. 22 Sep, 2020 1 commit
  18. 15 Sep, 2020 1 commit
    • Gaurav Jain's avatar
      SctPkg: Updated Start Address Alignment code · ed8a7477
      Gaurav Jain authored and G Edhaya Chandran's avatar G Edhaya Chandran committed
      REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2671
      
      
      
      AllocatePages Functionality test.
      Existing Code Increase Start address by 64k, even if Start is already aligned to 64k.
      
      Suggested Change will not modify Start,
      if Start is already aligned to 64k
      
      For Eg.
      Available Memory(Start is aligned to 64k):
      Start      End      PageNum(Free Pages)
      80000000  EBD6EFFF  6BD6F(Number of Free pages are not 64k Aligned)
      
      edk2-test code:
      Start is increased & aligned by 64k(Equal to 16 pages of size 4k each).
      Request for Pagenum is minus by 16 Pages.
      Start = (Start + 0x10000) & 0xFFFFFFFFFFFF0000 Start = (0x80000000 + 0x10000) & 0xFFFFFFFFFFFF0000 = 0x80010000 PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000) = 0x6BD6F - 0x10 = 0x6BD5F
      
      edk2 memory allocation code to Align the requested pages to 64k boundary:
      ------------------------------------------------------------------------
      NumberOfPages += EFI_SIZE_TO_PAGES(Alignment) - 1 = 0x6BD5F + 0xF = 0x6BD6E NumberOfPages &= ~(EFI_SIZE_TO_PAGES(Alignment) - 1) = 0x6BD6E & 0xFFFFFFF0
                                                           = 0x6BD60
      
      We can observe that requested pages is incraesed by 1 page, which results in below error.
      ConvertPages: range 80010000 - EBD6FFFF covers multiple entries.
      Signed-off-by: default avatarGaurav Jain <gaurav.jain@nxp.com>
      Reviewed-by: G Edhaya Chandran's avatarG Edhaya Chandran <edhaya.chandran@arm.com>
      
      Maintainer's Note: Rolling back the solution
      https://edk2.groups.io/g/devel/message/62055
      as it it failed in some implementations.
      
      Adding the solution as in the below message:
      https://edk2.groups.io/g/devel/message/58531
      ed8a7477
  19. 14 Sep, 2020 4 commits
  20. 16 Aug, 2020 2 commits
  21. 12 Aug, 2020 1 commit
    • Pankaj Bansal's avatar
      SctPkg: fix page alignment calculations · 93f402cf
      Pankaj Bansal authored and G Edhaya Chandran's avatar G Edhaya Chandran committed
      From: Pankaj Bansal <@pankaj.bansal>
      
      The BBTestAllocatePagesInterfaceTest tries to allocate pages for
      different memory types.
      While doing so, it tries to fix up the Start and PageNum for 64K
      Page size. There are multiple issues with this:
      
      1. 64K alignment is being done regardless of Processor type and Memory
         type. while this is correct for ARM64 Processor, it might not be so
         for other Processor types. Also 64K alignment for ARM64 Processor
         is needed for some Memory types not all.
      2. The Start is being incremented by 64K, even if Start is already 64K
         aligned.
      3. PageNum is being decreased by 16 pages indiscriminately, which might
         not be needed in all cases.
      
      fix all these issues by correctly doing the alignment in all needed
      cases.
      
      Cc: Paul Yang <@paulyang0125
      
      >
      Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
      Cc: Gaurav Jain <gaurav.jain@nxp.com>
      Signed-off-by: Pankaj Bansal <@pankaj.bansal>
      Tested-by: Samer El-Haj-Mahmoud's avatarSamer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
      Reviewed-by: G Edhaya Chandran's avatarG Edhaya Chandran <edhaya.chandran@arm.com>
      93f402cf