Skip to content
GitLab
Switch branch/tag
This project is mirrored from https://github.com/tianocore/edk2-test.git. Pull mirroring updated .
  1. 09 Dec, 2022 1 commit
  3. 30 Nov, 2022 1 commit
  5. 11 Nov, 2022 1 commit
  7. 07 Nov, 2022 1 commit
  9. 29 Sep, 2022 5 commits
  11. 19 Jul, 2022 1 commit
  13. 12 Apr, 2022 1 commit
    • G Edhaya Chandran's avatar
      UEFI-SCT: SctPkg: Updated the check for monotonic count after restart · dedfd87f
      G Edhaya Chandran authored 
      Updated the check for montonic count in the case of after restart

From the UEFI Spec:
"The platform?s monotonic counter is comprised of two parts: the high 32 bits and the low 32 bits.
The low 32-bit value is volatile and is reset to zero on every system reset.
It is increased by 1 on every call to GetNextMonotonicCount().
The high 32-bit value is nonvolatile and is increased by one on
whenever the system resets or the low 32-bit counter overflows."

It was found in one case where the higher 32-bit increased by 2
presumably due to the overflow of lower 32-bit counter.
Update the logic to handle this case and to print a warning.

Please find more details in the ticket: https://bugzilla.tianocore.org/show_bug.cgi?id=2774



Cc: Barton Gao <gaojie@byosoft.com.cn>
Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>

Signed-off-by: default avatarG Edhaya <Chandran&lt;edhaya.chandran@arm.com>
Reviewed-by: default avatarBarton Gao <gaojie@byosoft.com.cn>
      dedfd87f
  15. 03 Feb, 2022 2 commits
  17. 13 Jan, 2022 2 commits
  19. 25 Oct, 2021 2 commits
  21. 20 Sep, 2021 1 commit
  23. 07 Sep, 2021 1 commit
  25. 02 Sep, 2021 1 commit
  27. 23 Aug, 2021 1 commit
  29. 09 Aug, 2021 2 commits
    • Heinrich Schuchardt's avatar
      uefi-sct/SctPkg: uefi-sct:QueryVariableInfo(EFI_VARIABLE_NON_VOLATILE) · 814b2af5
      Heinrich Schuchardt authored and G Edhaya Chandran's avatar G Edhaya Chandran committed 
      REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3469



The Self Certification Test (SCT) II Case Specification, 2017 requires
in 5.2.1.4.5. that QueryVariableInfo() shall fail for

    attributes = EFI_VARIABLE_NON_VOLATILE.

Add EFI_VARIABLE_NON_VOLATILE to tested values in function
QueryVariableInfoConfTestSub5().

Signed-off-by: default avatarHeinrich Schuchardt <xypron.glpk@gmx.de>

Reviewed-by: default avatarG Edhaya <Chandran&lt;edhaya.chandran@arm.com>
      814b2af5
    • devel@edk2.groups.io's avatar
      uefi-sct/SctPkg: Update page alignment calculations · e4be3044
      devel@edk2.groups.io authored and G Edhaya Chandran's avatar G Edhaya Chandran committed 
      

This is to fix the SCT BS.AllocatePages failures (not found) with the case that the Start address is not aligned to 64k.
For example,
  The following is available memory region for testing:
    0000000082012000-00000000EB6D9FFF 00000000000696C8
  With the current page alignment calculation, we will get:
    Start address is 0x82020000
    PageNum is 0x696B8
  In BS.AllocatePages, it will make the end address align with 64k,
  so PageNum will be changed from 0x696B8 to 0x696C0. Therefore, the
  end address will become 0xEB6E0000 which is larger than 0xEB6D9FFF,
  so we get not found error in the end.

Therefore, the calculation for getting the PageNum should be updated to PageNum - (2 * EFI_SIZE_TO_PAGES(0x10000)) so that we won't get a wrong PageNum to allocate a memory with a size larger than available space's size.

With this solution, the example above will get 0x696A8 as calculated PageNum. Then, in BS.AllocatePages, the PageNum will be changed from
0x696A8 to 0x696B0. Therefore, the end address will become 0xEB6D0000 that is smaller than 0xEB6D9FFF, so we get not found error in the end.

I also tested this solution on two ARM platforms (NXP1046A and RPi4).

Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Cc: G Edhaya Chandran <edhaya.chandran@arm.com>
Cc: Barton Gao <gaojie@byosoft.com.cn>
Signed-off-by: Sunny Wang's avatarSunny Wang <sunny.wang@arm.com>

Reviewed-by: default avatarG Edhaya <Chandran&lt;edhaya.chandran@arm.com>
Reviewed-by: default avatarTuan Phan <tuanphan@os.amperecomputing.com>
      e4be3044
  31. 29 Jul, 2021 1 commit
  33. 16 Jun, 2021 1 commit
  35. 08 Jun, 2021 1 commit
  37. 12 May, 2021 2 commits
  39. 08 May, 2021 2 commits
  41. 06 May, 2021 3 commits
  43. 19 Mar, 2021 2 commits
  45. 03 Mar, 2021 1 commit
  47. 23 Feb, 2021 1 commit
  49. 22 Feb, 2021 3 commits