Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Edk2 Edk2
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • SystemReadySystemReady
  • firmware-build
  • Edk2Edk2
  • Repository
  • edk2
  • BaseTools
  • Source
  • Python
  • AutoGen
  • IncludesAutoGen.py
Find file BlameHistoryPermalink
  • Bob Feng's avatar
    BaseTools: Remove invalid leading space before !INCLUDE in Makefile · 2be4828a
    Bob Feng authored Feb 27, 2020
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2563
    
    This patch is to fix a incremental build regression bug
    which happen when using nmake. That's introduced by 818283de
    
    .
    
    If there is white space before !INCLUDE instruction, nmake will not
    process it. Source code's dependent header files are listed in
    ${deps_file} file, if it's not included successfully, nmake will
    not detect the change of those header file.
    
    This patch has been verified in Windows with VS2015 and Linux with GCC5.
    The header file add/modify/delete can trig the incremental build with this fix.
    There is no impact on the clean build.
    
    Cc: Andrew Fish <afish@apple.com>
    Cc: Laszlo Ersek <lersek@redhat.com>
    Cc: Leif Lindholm <leif@nuviainc.com>
    Cc: Michael D Kinney <michael.d.kinney@intel.com>
    Cc: Pierre Gondois <pierre.gondois@arm.com>
    Signed-off-by: default avatarBob Feng <bob.c.feng@intel.com>
    Acked-by: default avatarLaszlo Ersek <lersek@redhat.com>
    Reviewed-by: default avatarLiming Gao <liming.gao@intel.com>
    Tested-by: default avatarLiming Gao <liming.gao@intel.com>
    2be4828a